Commit 9f8c4265 authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by David S. Miller

sh_eth: fix result of sh_eth_check_reset() on timeout

When  the first loop in sh_eth_check_reset() runs to its end, 'cnt' is 0, so the
following check for 'cnt < 0' fails to catch the timeout.  Fix the  condition in
this check, so that the timeout  is actually reported.
While at it, fix the grammar in the failure message...
Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2786aae7
...@@ -897,8 +897,8 @@ static int sh_eth_check_reset(struct net_device *ndev) ...@@ -897,8 +897,8 @@ static int sh_eth_check_reset(struct net_device *ndev)
mdelay(1); mdelay(1);
cnt--; cnt--;
} }
if (cnt < 0) { if (cnt <= 0) {
pr_err("Device reset fail\n"); pr_err("Device reset failed\n");
ret = -ETIMEDOUT; ret = -ETIMEDOUT;
} }
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment