Commit a00eeede authored by Matt Redfearn's avatar Matt Redfearn Committed by Ralf Baechle

MIPS: SMP: Use a completion event to signal CPU up

If a secondary CPU failed to start, for any reason, the CPU requesting
the secondary to start would get stuck in the loop waiting for the
secondary to be present in the cpu_callin_map.

Rather than that, use a completion event to signal that the secondary
CPU has started and is waiting to synchronise counters.

Since the CPU presence will no longer be marked in cpu_callin_map,
remove the redundant test from arch_cpu_idle_dead().
Signed-off-by: default avatarMatt Redfearn <matt.redfearn@imgtec.com>
Cc: Maciej W. Rozycki <macro@imgtec.com>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Qais Yousef <qsyousef@gmail.com>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/14502/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 9799270a
...@@ -50,9 +50,7 @@ ...@@ -50,9 +50,7 @@
#ifdef CONFIG_HOTPLUG_CPU #ifdef CONFIG_HOTPLUG_CPU
void arch_cpu_idle_dead(void) void arch_cpu_idle_dead(void)
{ {
/* What the heck is this check doing ? */ play_dead();
if (!cpumask_test_cpu(smp_processor_id(), &cpu_callin_map))
play_dead();
} }
#endif #endif
......
...@@ -68,6 +68,8 @@ EXPORT_SYMBOL(cpu_sibling_map); ...@@ -68,6 +68,8 @@ EXPORT_SYMBOL(cpu_sibling_map);
cpumask_t cpu_core_map[NR_CPUS] __read_mostly; cpumask_t cpu_core_map[NR_CPUS] __read_mostly;
EXPORT_SYMBOL(cpu_core_map); EXPORT_SYMBOL(cpu_core_map);
static DECLARE_COMPLETION(cpu_running);
/* /*
* A logcal cpu mask containing only one VPE per core to * A logcal cpu mask containing only one VPE per core to
* reduce the number of IPIs on large MT systems. * reduce the number of IPIs on large MT systems.
...@@ -369,7 +371,7 @@ asmlinkage void start_secondary(void) ...@@ -369,7 +371,7 @@ asmlinkage void start_secondary(void)
cpumask_set_cpu(cpu, &cpu_coherent_mask); cpumask_set_cpu(cpu, &cpu_coherent_mask);
notify_cpu_starting(cpu); notify_cpu_starting(cpu);
cpumask_set_cpu(cpu, &cpu_callin_map); complete(&cpu_running);
synchronise_count_slave(cpu); synchronise_count_slave(cpu);
set_cpu_online(cpu, true); set_cpu_online(cpu, true);
...@@ -430,7 +432,6 @@ void smp_prepare_boot_cpu(void) ...@@ -430,7 +432,6 @@ void smp_prepare_boot_cpu(void)
{ {
set_cpu_possible(0, true); set_cpu_possible(0, true);
set_cpu_online(0, true); set_cpu_online(0, true);
cpumask_set_cpu(0, &cpu_callin_map);
} }
int __cpu_up(unsigned int cpu, struct task_struct *tidle) int __cpu_up(unsigned int cpu, struct task_struct *tidle)
...@@ -438,11 +439,13 @@ int __cpu_up(unsigned int cpu, struct task_struct *tidle) ...@@ -438,11 +439,13 @@ int __cpu_up(unsigned int cpu, struct task_struct *tidle)
mp_ops->boot_secondary(cpu, tidle); mp_ops->boot_secondary(cpu, tidle);
/* /*
* Trust is futile. We should really have timeouts ... * We must check for timeout here, as the CPU will not be marked
* online until the counters are synchronised.
*/ */
while (!cpumask_test_cpu(cpu, &cpu_callin_map)) { if (!wait_for_completion_timeout(&cpu_running,
udelay(100); msecs_to_jiffies(1000))) {
schedule(); pr_crit("CPU%u: failed to start\n", cpu);
return -EIO;
} }
synchronise_count_master(cpu); synchronise_count_master(cpu);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment