Commit a1b94355 authored by Colin Ian King's avatar Colin Ian King Committed by Sebastian Reichel

power: supply: bq2415x: check for NULL acpi_id to avoid null pointer dereference

acpi_match_device can potentially return NULL, so it is prudent to
check if acpi_id is null before it is dereferenced.  Add a check
and an error message to indicate the failure.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarPali Rohár <pali.rohar@gmail.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent cb190af2
...@@ -1569,6 +1569,11 @@ static int bq2415x_probe(struct i2c_client *client, ...@@ -1569,6 +1569,11 @@ static int bq2415x_probe(struct i2c_client *client,
acpi_id = acpi_id =
acpi_match_device(client->dev.driver->acpi_match_table, acpi_match_device(client->dev.driver->acpi_match_table,
&client->dev); &client->dev);
if (!acpi_id) {
dev_err(&client->dev, "failed to match device name\n");
ret = -ENODEV;
goto error_1;
}
name = kasprintf(GFP_KERNEL, "%s-%d", acpi_id->id, num); name = kasprintf(GFP_KERNEL, "%s-%d", acpi_id->id, num);
} }
if (!name) { if (!name) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment