Commit a1c30637 authored by Daniel Lezcano's avatar Daniel Lezcano Committed by Daniel Lezcano

thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp

The driver is assuming the get_critical temperature exists as it is
inherited by the thermal of ops. But this one has been removed in
favor of the generic one.

Use the generic thermal_zone_get_crit_temp() function instead

Fixes: 13bea86623be ("thermal/of: Remove of_thermal_get_crit_temp(")
Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent d3ecaf17
...@@ -264,9 +264,8 @@ static int exynos_tmu_initialize(struct platform_device *pdev) ...@@ -264,9 +264,8 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
unsigned int status; unsigned int status;
int ret = 0, temp; int ret = 0, temp;
if (data->soc != SOC_ARCH_EXYNOS5433) /* FIXME */ ret = thermal_zone_get_crit_temp(tzd, &temp);
ret = tzd->ops->get_crit_temp(tzd, &temp); if (ret && data->soc != SOC_ARCH_EXYNOS5433) { /* FIXME */
if (ret) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
"No CRITICAL trip point defined in device tree!\n"); "No CRITICAL trip point defined in device tree!\n");
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment