Commit a1cf1a5f authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij

pinctrl: mediatek: Convert to use grp member

Convert drivers to use grp member embedded in struct group_desc,
because other members will be removed to avoid duplication and
desynchronisation of the generic pin group description.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231211190321.307330-11-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent ffc1945e
...@@ -56,12 +56,12 @@ static int mtk_pinmux_set_mux(struct pinctrl_dev *pctldev, ...@@ -56,12 +56,12 @@ static int mtk_pinmux_set_mux(struct pinctrl_dev *pctldev,
return -EINVAL; return -EINVAL;
dev_dbg(pctldev->dev, "enable function %s group %s\n", dev_dbg(pctldev->dev, "enable function %s group %s\n",
func->name, grp->name); func->name, grp->grp.name);
for (i = 0; i < grp->num_pins; i++) { for (i = 0; i < grp->grp.npins; i++) {
const struct mtk_pin_desc *desc; const struct mtk_pin_desc *desc;
int *pin_modes = grp->data; int *pin_modes = grp->data;
int pin = grp->pins[i]; int pin = grp->grp.pins[i];
desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin]; desc = (const struct mtk_pin_desc *)&hw->soc->pins[pin];
if (!desc->name) if (!desc->name)
...@@ -602,13 +602,12 @@ static int mtk_build_groups(struct mtk_pinctrl *hw) ...@@ -602,13 +602,12 @@ static int mtk_build_groups(struct mtk_pinctrl *hw)
for (i = 0; i < hw->soc->ngrps; i++) { for (i = 0; i < hw->soc->ngrps; i++) {
const struct group_desc *group = hw->soc->grps + i; const struct group_desc *group = hw->soc->grps + i;
const struct pingroup *grp = &group->grp;
err = pinctrl_generic_add_group(hw->pctrl, group->name, err = pinctrl_generic_add_group(hw->pctrl, grp->name, grp->pins, grp->npins,
group->pins, group->num_pins,
group->data); group->data);
if (err < 0) { if (err < 0) {
dev_err(hw->dev, "Failed to register group %s\n", dev_err(hw->dev, "Failed to register group %s\n", grp->name);
group->name);
return err; return err;
} }
} }
......
...@@ -39,9 +39,7 @@ ...@@ -39,9 +39,7 @@
#define PINCTRL_PIN_GROUP(_name_, id) \ #define PINCTRL_PIN_GROUP(_name_, id) \
{ \ { \
.name = _name_, \ .grp = PINCTRL_PINGROUP(_name_, id##_pins, ARRAY_SIZE(id##_pins)), \
.pins = id##_pins, \
.num_pins = ARRAY_SIZE(id##_pins), \
.data = id##_funcs, \ .data = id##_funcs, \
} }
......
...@@ -51,9 +51,7 @@ ...@@ -51,9 +51,7 @@
#define PINCTRL_PIN_GROUP(_name_, id) \ #define PINCTRL_PIN_GROUP(_name_, id) \
{ \ { \
.name = _name_, \ .grp = PINCTRL_PINGROUP(_name_,id##_pins, ARRAY_SIZE(id##_pins)), \
.pins = id##_pins, \
.num_pins = ARRAY_SIZE(id##_pins), \
.data = id##_funcs, \ .data = id##_funcs, \
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment