Commit a24c1aab authored by Paul E. McKenney's avatar Paul E. McKenney

rcu: Mark rcu_cpu_kthread() accesses to ->rcu_cpu_has_work

The rcu_data structure's ->rcu_cpu_has_work field can be modified by
any CPU attempting to wake up the rcuc kthread.  Therefore, this commit
marks accesses to this field from the rcu_cpu_kthread() function.

This data race was reported by KCSAN.  Not appropriate for backporting
due to failure being unlikely.
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 9146eb25
...@@ -2481,12 +2481,12 @@ static void rcu_cpu_kthread(unsigned int cpu) ...@@ -2481,12 +2481,12 @@ static void rcu_cpu_kthread(unsigned int cpu)
*statusp = RCU_KTHREAD_RUNNING; *statusp = RCU_KTHREAD_RUNNING;
local_irq_disable(); local_irq_disable();
work = *workp; work = *workp;
*workp = 0; WRITE_ONCE(*workp, 0);
local_irq_enable(); local_irq_enable();
if (work) if (work)
rcu_core(); rcu_core();
local_bh_enable(); local_bh_enable();
if (*workp == 0) { if (!READ_ONCE(*workp)) {
trace_rcu_utilization(TPS("End CPU kthread@rcu_wait")); trace_rcu_utilization(TPS("End CPU kthread@rcu_wait"));
*statusp = RCU_KTHREAD_WAITING; *statusp = RCU_KTHREAD_WAITING;
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment