Commit a26f33c5 authored by Al Viro's avatar Al Viro Committed by Zefan Li

RCU pathwalk breakage when running into a symlink overmounting something

commit 3cab989a upstream.

Calling unlazy_walk() in walk_component() and do_last() when we find
a symlink that needs to be followed doesn't acquire a reference to vfsmount.
That's fine when the symlink is on the same vfsmount as the parent directory
(which is almost always the case), but it's not always true - one _can_
manage to bind a symlink on top of something.  And in such cases we end up
with excessive mntput().
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
[lizf: Backported to 3.4: drop the changes to do_last()]
Signed-off-by: default avatarZefan Li <lizefan@huawei.com>
parent 20db5788
...@@ -1314,7 +1314,8 @@ static inline int walk_component(struct nameidata *nd, struct path *path, ...@@ -1314,7 +1314,8 @@ static inline int walk_component(struct nameidata *nd, struct path *path,
} }
if (should_follow_link(inode, follow)) { if (should_follow_link(inode, follow)) {
if (nd->flags & LOOKUP_RCU) { if (nd->flags & LOOKUP_RCU) {
if (unlikely(unlazy_walk(nd, path->dentry))) { if (unlikely(nd->path.mnt != path->mnt ||
unlazy_walk(nd, path->dentry))) {
terminate_walk(nd); terminate_walk(nd);
return -ECHILD; return -ECHILD;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment