Commit a2e2d73f authored by Sean Young's avatar Sean Young Committed by Mauro Carvalho Chehab

media: rc: do not access device via sysfs after rc_unregister_device()

Device drivers do not expect to have change_protocol or wakeup
re-programming to be accesed after rc_unregister_device(). This can
cause the device driver to access deallocated resources.

Cc: <stable@vger.kernel.org> # 4.16+
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 4f0835d6
...@@ -1292,6 +1292,10 @@ static ssize_t store_protocols(struct device *device, ...@@ -1292,6 +1292,10 @@ static ssize_t store_protocols(struct device *device,
} }
mutex_lock(&dev->lock); mutex_lock(&dev->lock);
if (!dev->registered) {
mutex_unlock(&dev->lock);
return -ENODEV;
}
old_protocols = *current_protocols; old_protocols = *current_protocols;
new_protocols = old_protocols; new_protocols = old_protocols;
...@@ -1430,6 +1434,10 @@ static ssize_t store_filter(struct device *device, ...@@ -1430,6 +1434,10 @@ static ssize_t store_filter(struct device *device,
return -EINVAL; return -EINVAL;
mutex_lock(&dev->lock); mutex_lock(&dev->lock);
if (!dev->registered) {
mutex_unlock(&dev->lock);
return -ENODEV;
}
new_filter = *filter; new_filter = *filter;
if (fattr->mask) if (fattr->mask)
...@@ -1544,6 +1552,10 @@ static ssize_t store_wakeup_protocols(struct device *device, ...@@ -1544,6 +1552,10 @@ static ssize_t store_wakeup_protocols(struct device *device,
int i; int i;
mutex_lock(&dev->lock); mutex_lock(&dev->lock);
if (!dev->registered) {
mutex_unlock(&dev->lock);
return -ENODEV;
}
allowed = dev->allowed_wakeup_protocols; allowed = dev->allowed_wakeup_protocols;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment