Commit a3b4cbfc authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Marcel Holtmann

Bluetooth: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 710a9194
...@@ -106,7 +106,7 @@ static void bcm203x_complete(struct urb *urb) ...@@ -106,7 +106,7 @@ static void bcm203x_complete(struct urb *urb)
} }
data->state = BCM203X_LOAD_FIRMWARE; data->state = BCM203X_LOAD_FIRMWARE;
/* fall through */ fallthrough;
case BCM203X_LOAD_FIRMWARE: case BCM203X_LOAD_FIRMWARE:
if (data->fw_sent == data->fw_size) { if (data->fw_sent == data->fw_size) {
usb_fill_int_urb(urb, udev, usb_rcvintpipe(udev, BCM203X_IN_EP), usb_fill_int_urb(urb, udev, usb_rcvintpipe(udev, BCM203X_IN_EP),
......
...@@ -295,7 +295,6 @@ static void bluecard_write_wakeup(struct bluecard_info *info) ...@@ -295,7 +295,6 @@ static void bluecard_write_wakeup(struct bluecard_info *info)
baud_reg = REG_CONTROL_BAUD_RATE_115200; baud_reg = REG_CONTROL_BAUD_RATE_115200;
break; break;
case PKT_BAUD_RATE_57600: case PKT_BAUD_RATE_57600:
/* Fall through... */
default: default:
baud_reg = REG_CONTROL_BAUD_RATE_57600; baud_reg = REG_CONTROL_BAUD_RATE_57600;
break; break;
...@@ -585,7 +584,6 @@ static int bluecard_hci_set_baud_rate(struct hci_dev *hdev, int baud) ...@@ -585,7 +584,6 @@ static int bluecard_hci_set_baud_rate(struct hci_dev *hdev, int baud)
hci_skb_pkt_type(skb) = PKT_BAUD_RATE_115200; hci_skb_pkt_type(skb) = PKT_BAUD_RATE_115200;
break; break;
case 57600: case 57600:
/* Fall through... */
default: default:
cmd[4] = 0x03; cmd[4] = 0x03;
hci_skb_pkt_type(skb) = PKT_BAUD_RATE_57600; hci_skb_pkt_type(skb) = PKT_BAUD_RATE_57600;
......
...@@ -219,7 +219,7 @@ static void ll_device_want_to_wakeup(struct hci_uart *hu) ...@@ -219,7 +219,7 @@ static void ll_device_want_to_wakeup(struct hci_uart *hu)
* perfectly safe to always send one. * perfectly safe to always send one.
*/ */
BT_DBG("dual wake-up-indication"); BT_DBG("dual wake-up-indication");
/* fall through */ fallthrough;
case HCILL_ASLEEP: case HCILL_ASLEEP:
/* acknowledge device wake up */ /* acknowledge device wake up */
if (send_hcill_cmd(HCILL_WAKE_UP_ACK, hu) < 0) { if (send_hcill_cmd(HCILL_WAKE_UP_ACK, hu) < 0) {
......
...@@ -472,8 +472,6 @@ static void hci_ibs_tx_idle_timeout(struct timer_list *t) ...@@ -472,8 +472,6 @@ static void hci_ibs_tx_idle_timeout(struct timer_list *t)
case HCI_IBS_TX_ASLEEP: case HCI_IBS_TX_ASLEEP:
case HCI_IBS_TX_WAKING: case HCI_IBS_TX_WAKING:
/* Fall through */
default: default:
BT_ERR("Spurious timeout tx state %d", qca->tx_ibs_state); BT_ERR("Spurious timeout tx state %d", qca->tx_ibs_state);
break; break;
...@@ -516,8 +514,6 @@ static void hci_ibs_wake_retrans_timeout(struct timer_list *t) ...@@ -516,8 +514,6 @@ static void hci_ibs_wake_retrans_timeout(struct timer_list *t)
case HCI_IBS_TX_ASLEEP: case HCI_IBS_TX_ASLEEP:
case HCI_IBS_TX_AWAKE: case HCI_IBS_TX_AWAKE:
/* Fall through */
default: default:
BT_ERR("Spurious timeout tx state %d", qca->tx_ibs_state); BT_ERR("Spurious timeout tx state %d", qca->tx_ibs_state);
break; break;
...@@ -835,8 +831,6 @@ static void device_woke_up(struct hci_uart *hu) ...@@ -835,8 +831,6 @@ static void device_woke_up(struct hci_uart *hu)
break; break;
case HCI_IBS_TX_ASLEEP: case HCI_IBS_TX_ASLEEP:
/* Fall through */
default: default:
BT_ERR("Received HCI_IBS_WAKE_ACK in tx state %d", BT_ERR("Received HCI_IBS_WAKE_ACK in tx state %d",
qca->tx_ibs_state); qca->tx_ibs_state);
...@@ -2072,7 +2066,7 @@ static int __maybe_unused qca_suspend(struct device *dev) ...@@ -2072,7 +2066,7 @@ static int __maybe_unused qca_suspend(struct device *dev)
switch (qca->tx_ibs_state) { switch (qca->tx_ibs_state) {
case HCI_IBS_TX_WAKING: case HCI_IBS_TX_WAKING:
del_timer(&qca->wake_retrans_timer); del_timer(&qca->wake_retrans_timer);
/* Fall through */ fallthrough;
case HCI_IBS_TX_AWAKE: case HCI_IBS_TX_AWAKE:
del_timer(&qca->tx_idle_timer); del_timer(&qca->tx_idle_timer);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment