Commit a3fcccd4 authored by Stefan Agner's avatar Stefan Agner Committed by Greg Kroah-Hartman

usb: gadget: fsl_udc_core: fix ep valid checks

[ Upstream commit 20c63f40 ]

Clang reports the following warning:
  drivers/usb/gadget/udc/fsl_udc_core.c:1312:10: warning: address of array
  'ep->name' will always evaluate to 'true' [-Wpointer-bool-conversion]
        if (ep->name)
        ~~  ~~~~^~~~

It seems that the authors intention was to check if the ep has been
configured through struct_ep_setup. Check whether struct usb_ep name
pointer has been set instead.
Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 36d66139
...@@ -1309,7 +1309,7 @@ static void udc_reset_ep_queue(struct fsl_udc *udc, u8 pipe) ...@@ -1309,7 +1309,7 @@ static void udc_reset_ep_queue(struct fsl_udc *udc, u8 pipe)
{ {
struct fsl_ep *ep = get_ep_by_pipe(udc, pipe); struct fsl_ep *ep = get_ep_by_pipe(udc, pipe);
if (ep->name) if (ep->ep.name)
nuke(ep, -ESHUTDOWN); nuke(ep, -ESHUTDOWN);
} }
...@@ -1697,7 +1697,7 @@ static void dtd_complete_irq(struct fsl_udc *udc) ...@@ -1697,7 +1697,7 @@ static void dtd_complete_irq(struct fsl_udc *udc)
curr_ep = get_ep_by_pipe(udc, i); curr_ep = get_ep_by_pipe(udc, i);
/* If the ep is configured */ /* If the ep is configured */
if (curr_ep->name == NULL) { if (!curr_ep->ep.name) {
WARNING("Invalid EP?"); WARNING("Invalid EP?");
continue; continue;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment