Commit a447e38a authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini

KVM: VMX: Drop explicit 'nested' check from vmx_set_cr4()

Drop vmx_set_cr4()'s explicit check on the 'nested' module param now
that common x86 handles the check by incorporating VMXE into the CR4
reserved bits, via kvm_cpu_caps.  X86_FEATURE_VMX is set in kvm_cpu_caps
(by vmx_set_cpu_caps()), if and only if 'nested' is true.

No functional change intended.
Signed-off-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
Message-Id: <20201007014417.29276-3-sean.j.christopherson@intel.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent d3a9e414
...@@ -3123,18 +3123,13 @@ int vmx_set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4) ...@@ -3123,18 +3123,13 @@ int vmx_set_cr4(struct kvm_vcpu *vcpu, unsigned long cr4)
} }
} }
if (cr4 & X86_CR4_VMXE) { /*
/* * We operate under the default treatment of SMM, so VMX cannot be
* To use VMXON (and later other VMX instructions), a guest * enabled under SMM. Note, whether or not VMXE is allowed at all is
* must first be able to turn on cr4.VMXE (see handle_vmon()). * handled by kvm_valid_cr4().
* So basically the check on whether to allow nested VMX */
* is here. We operate under the default treatment of SMM, if ((cr4 & X86_CR4_VMXE) && is_smm(vcpu))
* so VMX cannot be enabled under SMM. Note, guest CPUID is return 1;
* intentionally ignored, it's handled by cr4_guest_rsvd_bits.
*/
if (!nested || is_smm(vcpu))
return 1;
}
if (vmx->nested.vmxon && !nested_cr4_valid(vcpu, cr4)) if (vmx->nested.vmxon && !nested_cr4_valid(vcpu, cr4))
return 1; return 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment