Commit a4485b0f authored by Nicolas Dichtel's avatar Nicolas Dichtel Committed by Kamal Mostafa

bridge/mdb: remove wrong use of NLM_F_MULTI

commit 82199679 upstream.

NLM_F_MULTI must be used only when a NLMSG_DONE message is sent. In fact,
it is sent only at the end of a dump.

Libraries like libnl will wait forever for NLMSG_DONE.

Fixes: 37a393bc ("bridge: notify mdb changes via netlink")
CC: Cong Wang <amwang@redhat.com>
CC: Stephen Hemminger <stephen@networkplumber.org>
CC: bridge@lists.linux-foundation.org
Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent a9560e98
...@@ -170,7 +170,7 @@ static int nlmsg_populate_mdb_fill(struct sk_buff *skb, ...@@ -170,7 +170,7 @@ static int nlmsg_populate_mdb_fill(struct sk_buff *skb,
struct br_port_msg *bpm; struct br_port_msg *bpm;
struct nlattr *nest, *nest2; struct nlattr *nest, *nest2;
nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI); nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0);
if (!nlh) if (!nlh)
return -EMSGSIZE; return -EMSGSIZE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment