Commit a4d22e33 authored by Bob Peterson's avatar Bob Peterson Committed by Andreas Gruenbacher

gfs2: move qdsb_put and reduce redundancy

This patch looks more invasive than it is. It simply moves function
qdsb_put before qd_unlock, then changes qd_unlock to call it rather than
open coding it. Again, this reduces redundancy.
Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent 03d468f1
...@@ -509,15 +509,20 @@ static int qd_fish(struct gfs2_sbd *sdp, struct gfs2_quota_data **qdp) ...@@ -509,15 +509,20 @@ static int qd_fish(struct gfs2_sbd *sdp, struct gfs2_quota_data **qdp)
return 0; return 0;
} }
static void qd_unlock(struct gfs2_quota_data *qd) static void qdsb_put(struct gfs2_quota_data *qd)
{ {
gfs2_assert_warn(qd->qd_sbd, test_bit(QDF_LOCKED, &qd->qd_flags));
clear_bit(QDF_LOCKED, &qd->qd_flags);
bh_put(qd); bh_put(qd);
slot_put(qd); slot_put(qd);
qd_put(qd); qd_put(qd);
} }
static void qd_unlock(struct gfs2_quota_data *qd)
{
gfs2_assert_warn(qd->qd_sbd, test_bit(QDF_LOCKED, &qd->qd_flags));
clear_bit(QDF_LOCKED, &qd->qd_flags);
qdsb_put(qd);
}
static int qdsb_get(struct gfs2_sbd *sdp, struct kqid qid, static int qdsb_get(struct gfs2_sbd *sdp, struct kqid qid,
struct gfs2_quota_data **qdp) struct gfs2_quota_data **qdp)
{ {
...@@ -544,13 +549,6 @@ static int qdsb_get(struct gfs2_sbd *sdp, struct kqid qid, ...@@ -544,13 +549,6 @@ static int qdsb_get(struct gfs2_sbd *sdp, struct kqid qid,
return error; return error;
} }
static void qdsb_put(struct gfs2_quota_data *qd)
{
bh_put(qd);
slot_put(qd);
qd_put(qd);
}
/** /**
* gfs2_qa_get - make sure we have a quota allocations data structure, * gfs2_qa_get - make sure we have a quota allocations data structure,
* if necessary * if necessary
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment