Commit a50fe0ff authored by Pan Bian's avatar Pan Bian Committed by David S. Miller

lwtunnel: check return value of nla_nest_start

Function nla_nest_start() may return a NULL pointer on error. However,
in function lwtunnel_fill_encap(), the return value of nla_nest_start()
is not validated before it is used. This patch checks the return value
of nla_nest_start() against NULL.
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 09d36071
...@@ -214,6 +214,8 @@ int lwtunnel_fill_encap(struct sk_buff *skb, struct lwtunnel_state *lwtstate) ...@@ -214,6 +214,8 @@ int lwtunnel_fill_encap(struct sk_buff *skb, struct lwtunnel_state *lwtstate)
ret = -EOPNOTSUPP; ret = -EOPNOTSUPP;
nest = nla_nest_start(skb, RTA_ENCAP); nest = nla_nest_start(skb, RTA_ENCAP);
if (!nest)
goto nla_put_failure;
rcu_read_lock(); rcu_read_lock();
ops = rcu_dereference(lwtun_encaps[lwtstate->type]); ops = rcu_dereference(lwtun_encaps[lwtstate->type]);
if (likely(ops && ops->fill_encap)) if (likely(ops && ops->fill_encap))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment