Commit a536b126 authored by Dave Jones's avatar Dave Jones

[CPUFREQ] Fix another notifier leak in powernow-k8.

Do the notifier registration later, so we don't have to worry
about freeing it if we fail the msr allocation.
Signed-off-by: default avatarDave Jones <davej@redhat.com>
parent ac818314
...@@ -1556,14 +1556,14 @@ static int __cpuinit powernowk8_init(void) ...@@ -1556,14 +1556,14 @@ static int __cpuinit powernowk8_init(void)
cpb_capable = true; cpb_capable = true;
register_cpu_notifier(&cpb_nb);
msrs = msrs_alloc(); msrs = msrs_alloc();
if (!msrs) { if (!msrs) {
printk(KERN_ERR "%s: Error allocating msrs!\n", __func__); printk(KERN_ERR "%s: Error allocating msrs!\n", __func__);
return -ENOMEM; return -ENOMEM;
} }
register_cpu_notifier(&cpb_nb);
rdmsr_on_cpus(cpu_online_mask, MSR_K7_HWCR, msrs); rdmsr_on_cpus(cpu_online_mask, MSR_K7_HWCR, msrs);
for_each_cpu(cpu, cpu_online_mask) { for_each_cpu(cpu, cpu_online_mask) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment