Commit a58567d7 authored by Chris Wilson's avatar Chris Wilson Committed by Luis Henriques

drm/i915: Only warn the first time we attempt to mmio whilst suspended

commit 2b387059 upstream.

In all likelihood we will do a few hundred errnoneous register
operations if we do a single invalid register access whilst the device
is suspended. As each instance causes a WARN, this floods the system
logs and can make the system unresponsive.

The warning was first introduced in
commit b2ec142c
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date:   Fri Feb 21 13:52:25 2014 -0300

    drm/i915: call assert_device_not_suspended at gen6_force_wake_work

and despite the claims the WARN is still encountered in the wild today.
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 8a60f63d
...@@ -43,7 +43,7 @@ ...@@ -43,7 +43,7 @@
static void static void
assert_device_not_suspended(struct drm_i915_private *dev_priv) assert_device_not_suspended(struct drm_i915_private *dev_priv)
{ {
WARN(HAS_RUNTIME_PM(dev_priv->dev) && dev_priv->pm.suspended, WARN_ONCE(HAS_RUNTIME_PM(dev_priv->dev) && dev_priv->pm.suspended,
"Device suspended\n"); "Device suspended\n");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment