Commit a5bbcbf2 authored by Taehee Yoo's avatar Taehee Yoo Committed by Jakub Kicinski

netdevsim: set .owner to THIS_MODULE

If THIS_MODULE is not set, the module would be removed while debugfs is
being used.
It eventually makes kernel panic.

Fixes: 82c93a87 ("netdevsim: implement couple of testing devlink health reporters")
Fixes: 424be63a ("netdevsim: add UDP tunnel port offload support")
Fixes: 4418f862 ("netdevsim: implement support for devlink region and snapshots")
Fixes: d3cbb907 ("netdevsim: add ACL trap reporting cookie as a metadata")
Signed-off-by: default avatarTaehee Yoo <ap420073@gmail.com>
Link: https://lore.kernel.org/r/20201115103041.30701-1-ap420073@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fd5736bf
...@@ -96,6 +96,7 @@ static const struct file_operations nsim_dev_take_snapshot_fops = { ...@@ -96,6 +96,7 @@ static const struct file_operations nsim_dev_take_snapshot_fops = {
.open = simple_open, .open = simple_open,
.write = nsim_dev_take_snapshot_write, .write = nsim_dev_take_snapshot_write,
.llseek = generic_file_llseek, .llseek = generic_file_llseek,
.owner = THIS_MODULE,
}; };
static ssize_t nsim_dev_trap_fa_cookie_read(struct file *file, static ssize_t nsim_dev_trap_fa_cookie_read(struct file *file,
...@@ -188,6 +189,7 @@ static const struct file_operations nsim_dev_trap_fa_cookie_fops = { ...@@ -188,6 +189,7 @@ static const struct file_operations nsim_dev_trap_fa_cookie_fops = {
.read = nsim_dev_trap_fa_cookie_read, .read = nsim_dev_trap_fa_cookie_read,
.write = nsim_dev_trap_fa_cookie_write, .write = nsim_dev_trap_fa_cookie_write,
.llseek = generic_file_llseek, .llseek = generic_file_llseek,
.owner = THIS_MODULE,
}; };
static int nsim_dev_debugfs_init(struct nsim_dev *nsim_dev) static int nsim_dev_debugfs_init(struct nsim_dev *nsim_dev)
......
...@@ -261,6 +261,7 @@ static const struct file_operations nsim_dev_health_break_fops = { ...@@ -261,6 +261,7 @@ static const struct file_operations nsim_dev_health_break_fops = {
.open = simple_open, .open = simple_open,
.write = nsim_dev_health_break_write, .write = nsim_dev_health_break_write,
.llseek = generic_file_llseek, .llseek = generic_file_llseek,
.owner = THIS_MODULE,
}; };
int nsim_dev_health_init(struct nsim_dev *nsim_dev, struct devlink *devlink) int nsim_dev_health_init(struct nsim_dev *nsim_dev, struct devlink *devlink)
......
...@@ -124,6 +124,7 @@ static const struct file_operations nsim_udp_tunnels_info_reset_fops = { ...@@ -124,6 +124,7 @@ static const struct file_operations nsim_udp_tunnels_info_reset_fops = {
.open = simple_open, .open = simple_open,
.write = nsim_udp_tunnels_info_reset_write, .write = nsim_udp_tunnels_info_reset_write,
.llseek = generic_file_llseek, .llseek = generic_file_llseek,
.owner = THIS_MODULE,
}; };
int nsim_udp_tunnels_info_create(struct nsim_dev *nsim_dev, int nsim_udp_tunnels_info_create(struct nsim_dev *nsim_dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment