Commit a6a5eccc authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Benjamin Tissoires

HID: cp2112: Use octal permissions

Octal permissions are preferred as stated in
Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions
with octal permissions when creating the files.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230703185222.50554-13-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarBenjamin Tissoires <bentiss@kernel.org>
parent 7f758125
...@@ -175,7 +175,7 @@ struct cp2112_device { ...@@ -175,7 +175,7 @@ struct cp2112_device {
}; };
static int gpio_push_pull = CP2112_GPIO_ALL_GPIO_MASK; static int gpio_push_pull = CP2112_GPIO_ALL_GPIO_MASK;
module_param(gpio_push_pull, int, S_IRUGO | S_IWUSR); module_param(gpio_push_pull, int, 0644);
MODULE_PARM_DESC(gpio_push_pull, "GPIO push-pull configuration bitmask"); MODULE_PARM_DESC(gpio_push_pull, "GPIO push-pull configuration bitmask");
static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset) static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
...@@ -1057,7 +1057,7 @@ static void chmod_sysfs_attrs(struct hid_device *hdev) ...@@ -1057,7 +1057,7 @@ static void chmod_sysfs_attrs(struct hid_device *hdev)
} }
for (attr = cp2112_attr_group.attrs; *attr; ++attr) { for (attr = cp2112_attr_group.attrs; *attr; ++attr) {
umode_t mode = (buf[1] & 1) ? S_IWUSR | S_IRUGO : S_IRUGO; umode_t mode = (buf[1] & 1) ? 0644 : 0444;
ret = sysfs_chmod_file(&hdev->dev.kobj, *attr, mode); ret = sysfs_chmod_file(&hdev->dev.kobj, *attr, mode);
if (ret < 0) if (ret < 0)
hid_err(hdev, "error chmoding sysfs file %s\n", hid_err(hdev, "error chmoding sysfs file %s\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment