Commit a78b41d5 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

[media] mb86a20s: Always reset the frontend with set_frontend

Always init the frontend when set_frontend is called. The rationale
is: it was noticed that, on some devices, it fails to lock with a
different channel. It seems that some other registers need to be
restored to its initial state, when the channel changes.
As it is better to reset everything, even wasting a few more
miliseconds than to loose channel lock, let's change the logic
to always reset.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 17e67d4c
...@@ -1854,18 +1854,9 @@ static int mb86a20s_set_frontend(struct dvb_frontend *fe) ...@@ -1854,18 +1854,9 @@ static int mb86a20s_set_frontend(struct dvb_frontend *fe)
fe->ops.i2c_gate_ctrl(fe, 1); fe->ops.i2c_gate_ctrl(fe, 1);
fe->ops.tuner_ops.set_params(fe); fe->ops.tuner_ops.set_params(fe);
if (fe->ops.tuner_ops.get_if_frequency) { if (fe->ops.tuner_ops.get_if_frequency)
fe->ops.tuner_ops.get_if_frequency(fe, &if_freq); fe->ops.tuner_ops.get_if_frequency(fe, &if_freq);
/*
* If the IF frequency changed, re-initialize the
* frontend. This is needed by some drivers like tda18271,
* that only sets the IF after receiving a set_params() call
*/
if (if_freq != state->if_freq)
state->need_init = true;
}
/* /*
* Make it more reliable: if, for some reason, the initial * Make it more reliable: if, for some reason, the initial
* device initialization doesn't happen, initialize it when * device initialization doesn't happen, initialize it when
...@@ -1877,9 +1868,13 @@ static int mb86a20s_set_frontend(struct dvb_frontend *fe) ...@@ -1877,9 +1868,13 @@ static int mb86a20s_set_frontend(struct dvb_frontend *fe)
* So, this hack is needed, in order to make Kworld SBTVD to work. * So, this hack is needed, in order to make Kworld SBTVD to work.
* *
* It is also needed to change the IF after the initial init. * It is also needed to change the IF after the initial init.
*
* HACK: Always init the frontend when set_frontend is called:
* it was noticed that, on some devices, it fails to lock on a
* different channel. So, it is better to reset everything, even
* wasting some time, than to loose channel lock.
*/ */
if (state->need_init) mb86a20s_initfe(fe);
mb86a20s_initfe(fe);
if (fe->ops.i2c_gate_ctrl) if (fe->ops.i2c_gate_ctrl)
fe->ops.i2c_gate_ctrl(fe, 0); fe->ops.i2c_gate_ctrl(fe, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment