Commit a7fdb6e6 authored by Joerg Roedel's avatar Joerg Roedel

iommu/vt-d: Fix crash when accessing VT-d sysfs entries

The link between the iommu sysfs-device and the struct
intel_iommu is no longer stored as driver-data. Update the
code to use the new access method.
Reported-by: default avatarDave Jones <davej@codemonkey.org.uk>
Fixes: 39ab9555 ('iommu: Add sysfs bindings for struct iommu_device')
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 86292b33
...@@ -4730,11 +4730,16 @@ static int intel_iommu_cpu_dead(unsigned int cpu) ...@@ -4730,11 +4730,16 @@ static int intel_iommu_cpu_dead(unsigned int cpu)
return 0; return 0;
} }
static inline struct intel_iommu *dev_to_intel_iommu(struct device *dev)
{
return container_of(dev, struct intel_iommu, iommu.dev);
}
static ssize_t intel_iommu_show_version(struct device *dev, static ssize_t intel_iommu_show_version(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct intel_iommu *iommu = dev_get_drvdata(dev); struct intel_iommu *iommu = dev_to_intel_iommu(dev);
u32 ver = readl(iommu->reg + DMAR_VER_REG); u32 ver = readl(iommu->reg + DMAR_VER_REG);
return sprintf(buf, "%d:%d\n", return sprintf(buf, "%d:%d\n",
DMAR_VER_MAJOR(ver), DMAR_VER_MINOR(ver)); DMAR_VER_MAJOR(ver), DMAR_VER_MINOR(ver));
...@@ -4745,7 +4750,7 @@ static ssize_t intel_iommu_show_address(struct device *dev, ...@@ -4745,7 +4750,7 @@ static ssize_t intel_iommu_show_address(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct intel_iommu *iommu = dev_get_drvdata(dev); struct intel_iommu *iommu = dev_to_intel_iommu(dev);
return sprintf(buf, "%llx\n", iommu->reg_phys); return sprintf(buf, "%llx\n", iommu->reg_phys);
} }
static DEVICE_ATTR(address, S_IRUGO, intel_iommu_show_address, NULL); static DEVICE_ATTR(address, S_IRUGO, intel_iommu_show_address, NULL);
...@@ -4754,7 +4759,7 @@ static ssize_t intel_iommu_show_cap(struct device *dev, ...@@ -4754,7 +4759,7 @@ static ssize_t intel_iommu_show_cap(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct intel_iommu *iommu = dev_get_drvdata(dev); struct intel_iommu *iommu = dev_to_intel_iommu(dev);
return sprintf(buf, "%llx\n", iommu->cap); return sprintf(buf, "%llx\n", iommu->cap);
} }
static DEVICE_ATTR(cap, S_IRUGO, intel_iommu_show_cap, NULL); static DEVICE_ATTR(cap, S_IRUGO, intel_iommu_show_cap, NULL);
...@@ -4763,7 +4768,7 @@ static ssize_t intel_iommu_show_ecap(struct device *dev, ...@@ -4763,7 +4768,7 @@ static ssize_t intel_iommu_show_ecap(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct intel_iommu *iommu = dev_get_drvdata(dev); struct intel_iommu *iommu = dev_to_intel_iommu(dev);
return sprintf(buf, "%llx\n", iommu->ecap); return sprintf(buf, "%llx\n", iommu->ecap);
} }
static DEVICE_ATTR(ecap, S_IRUGO, intel_iommu_show_ecap, NULL); static DEVICE_ATTR(ecap, S_IRUGO, intel_iommu_show_ecap, NULL);
...@@ -4772,7 +4777,7 @@ static ssize_t intel_iommu_show_ndoms(struct device *dev, ...@@ -4772,7 +4777,7 @@ static ssize_t intel_iommu_show_ndoms(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct intel_iommu *iommu = dev_get_drvdata(dev); struct intel_iommu *iommu = dev_to_intel_iommu(dev);
return sprintf(buf, "%ld\n", cap_ndoms(iommu->cap)); return sprintf(buf, "%ld\n", cap_ndoms(iommu->cap));
} }
static DEVICE_ATTR(domains_supported, S_IRUGO, intel_iommu_show_ndoms, NULL); static DEVICE_ATTR(domains_supported, S_IRUGO, intel_iommu_show_ndoms, NULL);
...@@ -4781,7 +4786,7 @@ static ssize_t intel_iommu_show_ndoms_used(struct device *dev, ...@@ -4781,7 +4786,7 @@ static ssize_t intel_iommu_show_ndoms_used(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct intel_iommu *iommu = dev_get_drvdata(dev); struct intel_iommu *iommu = dev_to_intel_iommu(dev);
return sprintf(buf, "%d\n", bitmap_weight(iommu->domain_ids, return sprintf(buf, "%d\n", bitmap_weight(iommu->domain_ids,
cap_ndoms(iommu->cap))); cap_ndoms(iommu->cap)));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment