Commit a7ff51fe authored by Geliang Tang's avatar Geliang Tang Committed by Kamal Mostafa

hsi: fix double kfree

commit f098a045 upstream.

When device_register() fails, kfree() is called in hsi_client_release(),
hence there is no need to call kfree in err3 again.

Fixes: a2aa2473 ("HSI: Add common DT binding for HSI client devices")
Signed-off-by: default avatarGeliang Tang <geliangtang@163.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 523ec185
...@@ -300,7 +300,6 @@ static void hsi_add_client_from_dt(struct hsi_port *port, ...@@ -300,7 +300,6 @@ static void hsi_add_client_from_dt(struct hsi_port *port,
if (device_register(&cl->device) < 0) { if (device_register(&cl->device) < 0) {
pr_err("hsi: failed to register client: %s\n", name); pr_err("hsi: failed to register client: %s\n", name);
put_device(&cl->device); put_device(&cl->device);
goto err3;
} }
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment