Commit a84324d2 authored by Damien Le Moal's avatar Damien Le Moal Committed by Jens Axboe

block: Remove REQ_OP_ZONE_RESET plugging

REQ_OP_ZONE_RESET operations cannot be merged as these bios and requests
do not have a size and are never sequential due to the zone start sector
position required for their execution. As a result, there is no point in
using a plug around blkdev_reset_zones() bio issuing loop. This patch
removes this unnecessary plugging.
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: default avatarJavier González <javier@javigon.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent f8db3835
...@@ -258,7 +258,6 @@ int blkdev_reset_zones(struct block_device *bdev, ...@@ -258,7 +258,6 @@ int blkdev_reset_zones(struct block_device *bdev,
sector_t zone_sectors; sector_t zone_sectors;
sector_t end_sector = sector + nr_sectors; sector_t end_sector = sector + nr_sectors;
struct bio *bio = NULL; struct bio *bio = NULL;
struct blk_plug plug;
int ret; int ret;
if (!blk_queue_is_zoned(q)) if (!blk_queue_is_zoned(q))
...@@ -283,7 +282,6 @@ int blkdev_reset_zones(struct block_device *bdev, ...@@ -283,7 +282,6 @@ int blkdev_reset_zones(struct block_device *bdev,
end_sector != bdev->bd_part->nr_sects) end_sector != bdev->bd_part->nr_sects)
return -EINVAL; return -EINVAL;
blk_start_plug(&plug);
while (sector < end_sector) { while (sector < end_sector) {
bio = blk_next_bio(bio, 0, gfp_mask); bio = blk_next_bio(bio, 0, gfp_mask);
...@@ -301,8 +299,6 @@ int blkdev_reset_zones(struct block_device *bdev, ...@@ -301,8 +299,6 @@ int blkdev_reset_zones(struct block_device *bdev,
ret = submit_bio_wait(bio); ret = submit_bio_wait(bio);
bio_put(bio); bio_put(bio);
blk_finish_plug(&plug);
return ret; return ret;
} }
EXPORT_SYMBOL_GPL(blkdev_reset_zones); EXPORT_SYMBOL_GPL(blkdev_reset_zones);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment