Commit a88086e0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jens Axboe

net: off by one in inet6_pton()

If "scope_len" is sizeof(scope_id) then we would put the NUL terminator
one space beyond the end of the buffer.

Fixes: b1a951fe ("net/utils: generic inet_pton_with_scope helper")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 00e04393
...@@ -339,7 +339,7 @@ static int inet6_pton(struct net *net, const char *src, u16 port_num, ...@@ -339,7 +339,7 @@ static int inet6_pton(struct net *net, const char *src, u16 port_num,
src + srclen != scope_delim && *scope_delim == '%') { src + srclen != scope_delim && *scope_delim == '%') {
struct net_device *dev; struct net_device *dev;
char scope_id[16]; char scope_id[16];
size_t scope_len = min_t(size_t, sizeof(scope_id), size_t scope_len = min_t(size_t, sizeof(scope_id) - 1,
src + srclen - scope_delim - 1); src + srclen - scope_delim - 1);
memcpy(scope_id, scope_delim + 1, scope_len); memcpy(scope_id, scope_delim + 1, scope_len);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment