Commit a890062b authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: ke_counter: cleanup "find pci device" code

Cleanup the "find pci device" code so that it follows the style
of the other comedi pci drivers.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bd8a9bc1
...@@ -125,49 +125,35 @@ static int cnt_rinsn(struct comedi_device *dev, ...@@ -125,49 +125,35 @@ static int cnt_rinsn(struct comedi_device *dev,
static struct pci_dev *cnt_find_pci_dev(struct comedi_device *dev, static struct pci_dev *cnt_find_pci_dev(struct comedi_device *dev,
struct comedi_devconfig *it) struct comedi_devconfig *it)
{ {
struct cnt_board_struct *board; const struct cnt_board_struct *board;
struct pci_dev *pci_device = NULL; struct pci_dev *pcidev = NULL;
int bus = it->options[0];
int slot = it->options[1];
int i; int i;
/* Probe the device to determine what device in the series it is. */ /* Probe the device to determine what device in the series it is. */
for_each_pci_dev(pci_device) { for_each_pci_dev(pcidev) {
if (pci_device->vendor == PCI_VENDOR_ID_KOLTER) { if (bus || slot) {
for (i = 0; i < cnt_board_nbr; i++) { if (pcidev->bus->number != bus ||
if (cnt_boards[i].device_id == PCI_SLOT(pcidev->devfn) != slot)
pci_device->device) { continue;
/* was a particular bus/slot requested? */ }
if ((it->options[0] != 0) if (pcidev->vendor != PCI_VENDOR_ID_KOLTER)
|| (it->options[1] != 0)) { continue;
/* are we on the wrong bus/slot? */
if (pci_device->bus->number != for (i = 0; i < cnt_board_nbr; i++) {
it->options[0] board = &cnt_boards[i];
|| if (board->device_id != pcidev->device)
PCI_SLOT(pci_device->devfn) continue;
!= it->options[1]) {
continue; dev->board_ptr = board;
} return pcidev;
}
dev->board_ptr = cnt_boards + i;
board =
(struct cnt_board_struct *)
dev->board_ptr;
goto found;
}
}
} }
} }
printk(KERN_WARNING dev_err(dev->class_dev,
"comedi%d: no supported board found! (req. bus/slot: %d/%d)\n", "No supported board found! (req. bus %d, slot %d)\n",
dev->minor, it->options[0], it->options[1]); bus, slot);
return NULL; return NULL;
found:
printk(KERN_INFO
"comedi%d: found %s at PCI bus %d, slot %d\n", dev->minor,
board->name, pci_device->bus->number,
PCI_SLOT(pci_device->devfn));
return pci_device;
} }
static int cnt_attach(struct comedi_device *dev, struct comedi_devconfig *it) static int cnt_attach(struct comedi_device *dev, struct comedi_devconfig *it)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment