Commit a960ff81 authored by Timo Teräs's avatar Timo Teräs Committed by David S. Miller

neigh: probe application via netlink in NUD_PROBE

iproute2 arpd seems to expect this as there's code and comments
to handle netlink probes with NUD_PROBE set. It is used to flush
the arpd cached mappings.

opennhrp instead turns off unicast probes (so it can handle all
neighbour discovery). Without this change it will not see NUD_PROBE
probes and cannot reconfirm the mapping. Thus currently neigh entry
will just fail and can cause few packets dropped until broadcast
discovery is restarted.

Earlier discussion on the subject:
http://marc.info/?t=139305877100001&r=1&w=2Signed-off-by: default avatarTimo Teräs <timo.teras@iki.fi>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 44a6bd86
...@@ -836,10 +836,10 @@ static void neigh_periodic_work(struct work_struct *work) ...@@ -836,10 +836,10 @@ static void neigh_periodic_work(struct work_struct *work)
static __inline__ int neigh_max_probes(struct neighbour *n) static __inline__ int neigh_max_probes(struct neighbour *n)
{ {
struct neigh_parms *p = n->parms; struct neigh_parms *p = n->parms;
return (n->nud_state & NUD_PROBE) ? int max_probes = NEIGH_VAR(p, UCAST_PROBES) + NEIGH_VAR(p, APP_PROBES);
NEIGH_VAR(p, UCAST_PROBES) : if (!(n->nud_state & NUD_PROBE))
NEIGH_VAR(p, UCAST_PROBES) + NEIGH_VAR(p, APP_PROBES) + max_probes += NEIGH_VAR(p, MCAST_PROBES);
NEIGH_VAR(p, MCAST_PROBES); return max_probes;
} }
static void neigh_invalidate(struct neighbour *neigh) static void neigh_invalidate(struct neighbour *neigh)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment