Commit a97f4a66 authored by Bart Van Assche's avatar Bart Van Assche Committed by David Teigland

dlm: Avoid that dlm_release_lockspace() incorrectly returns -EBUSY

When dlm_release_lockspace(ls, 1) is invoked on a busy system
immediately after the last dlm_unlock() AST has finished it can occur
that lkb_idr_is_local() is invoked for the unlocked LKB since removal
from ls_lkbidr only occurs after the AST has returned. If that happens
dlm_release_lockspace(ls, 1) will return -EBUSY instead of releasing
the lockspace. Fix this race condition by changing lkb_idr_is_local()
such that it only returns true for LKB's that have not yet been
unlocked.
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
parent 34ec4de4
...@@ -706,9 +706,7 @@ static int lkb_idr_is_local(int id, void *p, void *data) ...@@ -706,9 +706,7 @@ static int lkb_idr_is_local(int id, void *p, void *data)
{ {
struct dlm_lkb *lkb = p; struct dlm_lkb *lkb = p;
if (!lkb->lkb_nodeid) return lkb->lkb_nodeid == 0 && lkb->lkb_grmode != DLM_LOCK_IV;
return 1;
return 0;
} }
static int lkb_idr_is_any(int id, void *p, void *data) static int lkb_idr_is_any(int id, void *p, void *data)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment