Commit a9face89 authored by Dan Carpenter's avatar Dan Carpenter Committed by Rafael J. Wysocki

usb: typec: ucsi: acpi: fix a NULL vs IS_ERR() check in probe

The devm_memremap() function never returns NULL.  It returns error
pointers.

Fixes: cdc3d2ab ("usb: typec: ucsi: acpi: Map the mailbox with memremap()")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent b941820e
...@@ -133,8 +133,8 @@ static int ucsi_acpi_probe(struct platform_device *pdev) ...@@ -133,8 +133,8 @@ static int ucsi_acpi_probe(struct platform_device *pdev)
} }
ua->base = devm_memremap(&pdev->dev, res->start, resource_size(res), MEMREMAP_WB); ua->base = devm_memremap(&pdev->dev, res->start, resource_size(res), MEMREMAP_WB);
if (!ua->base) if (IS_ERR(ua->base))
return -ENOMEM; return PTR_ERR(ua->base);
ret = guid_parse(UCSI_DSM_UUID, &ua->guid); ret = guid_parse(UCSI_DSM_UUID, &ua->guid);
if (ret) if (ret)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment