Commit aa9a4a1e authored by Liu ShuoX's avatar Liu ShuoX Committed by Tony Luck

pstore: skip zero size persistent ram buffer in traverse

In ramoops_pstore_read, a valid prz pointer with zero size buffer will
break traverse of all persistent ram buffers.  The latter buffer might be
lost.
Signed-off-by: default avatarLiu ShuoX <shuox.liu@intel.com>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Colin Cross <ccross@android.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
parent 57fd8353
...@@ -120,12 +120,12 @@ ramoops_get_next_prz(struct persistent_ram_zone *przs[], uint *c, uint max, ...@@ -120,12 +120,12 @@ ramoops_get_next_prz(struct persistent_ram_zone *przs[], uint *c, uint max,
prz = przs[i]; prz = przs[i];
if (update) { /* Update old/shadowed buffer. */
/* Update old/shadowed buffer. */ if (update)
persistent_ram_save_old(prz); persistent_ram_save_old(prz);
if (!persistent_ram_old_size(prz))
return NULL; if (!persistent_ram_old_size(prz))
} return NULL;
*typep = type; *typep = type;
*id = i; *id = i;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment