Commit aaa3cbba authored by Qiushi Wu's avatar Qiushi Wu Committed by Enric Balletbo i Serra

platform/chrome: cros_ec_ishtp: Fix a double-unlock issue

In function cros_ec_ishtp_probe(), "up_write" is already called
before function "cros_ec_dev_init". But "up_write" will be called
again after the calling of the function "cros_ec_dev_init" failed.
Thus add a call of the function “down_write” in this if branch
for the completion of the exception handling.

Fixes: 26a14267 ("platform/chrome: Add ChromeOS EC ISHTP driver")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Tested-by: default avatarMathew King <mathewk@chromium.org>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
parent 9a876ba5
...@@ -681,8 +681,10 @@ static int cros_ec_ishtp_probe(struct ishtp_cl_device *cl_device) ...@@ -681,8 +681,10 @@ static int cros_ec_ishtp_probe(struct ishtp_cl_device *cl_device)
/* Register croc_ec_dev mfd */ /* Register croc_ec_dev mfd */
rv = cros_ec_dev_init(client_data); rv = cros_ec_dev_init(client_data);
if (rv) if (rv) {
down_write(&init_lock);
goto end_cros_ec_dev_init_error; goto end_cros_ec_dev_init_error;
}
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment