Commit aab439ff authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Williamson

vfio/pci: clean up a type in vfio_pci_ioctl_pci_hot_reset_groups()

The "array_count" value comes from the copy_from_user() in
vfio_pci_ioctl_pci_hot_reset().  If the user passes a value larger than
INT_MAX then we'll pass a negative value to kcalloc() which triggers an
allocation failure and a stack trace.

It's better to make the type unsigned so that if (array_count > count)
returns -EINVAL instead.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/262ada03-d848-4369-9c37-81edeeed2da2@stanley.mountainSigned-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent 27a8204b
...@@ -1323,7 +1323,7 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info( ...@@ -1323,7 +1323,7 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info(
static int static int
vfio_pci_ioctl_pci_hot_reset_groups(struct vfio_pci_core_device *vdev, vfio_pci_ioctl_pci_hot_reset_groups(struct vfio_pci_core_device *vdev,
int array_count, bool slot, u32 array_count, bool slot,
struct vfio_pci_hot_reset __user *arg) struct vfio_pci_hot_reset __user *arg)
{ {
int32_t *group_fds; int32_t *group_fds;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment