Commit aba84871 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Jakub Kicinski

net: pasemi: fix error return code in pasemi_mac_open()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 72b05b99 ("pasemi_mac: RX/TX ring management cleanup")
Fixes: 8d636d8b ("pasemi_mac: jumbo frame support")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1606903035-1838-1-git-send-email-zhangchangzhong@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ff992489
...@@ -1078,16 +1078,20 @@ static int pasemi_mac_open(struct net_device *dev) ...@@ -1078,16 +1078,20 @@ static int pasemi_mac_open(struct net_device *dev)
mac->tx = pasemi_mac_setup_tx_resources(dev); mac->tx = pasemi_mac_setup_tx_resources(dev);
if (!mac->tx) if (!mac->tx) {
ret = -ENOMEM;
goto out_tx_ring; goto out_tx_ring;
}
/* We might already have allocated rings in case mtu was changed /* We might already have allocated rings in case mtu was changed
* before interface was brought up. * before interface was brought up.
*/ */
if (dev->mtu > 1500 && !mac->num_cs) { if (dev->mtu > 1500 && !mac->num_cs) {
pasemi_mac_setup_csrings(mac); pasemi_mac_setup_csrings(mac);
if (!mac->num_cs) if (!mac->num_cs) {
ret = -ENOMEM;
goto out_tx_ring; goto out_tx_ring;
}
} }
/* Zero out rmon counters */ /* Zero out rmon counters */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment