Commit abe42b09 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown

ASoC: dt-bindings: Correct interrupt flags in examples

GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted some
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Acked-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20200908145954.4629-1-krzk@kernel.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent cac17861
...@@ -55,5 +55,5 @@ audio-codec@10 { ...@@ -55,5 +55,5 @@ audio-codec@10 {
compatible = "maxim,max98090"; compatible = "maxim,max98090";
reg = <0x10>; reg = <0x10>;
interrupt-parent = <&gpio>; interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(H, 4) GPIO_ACTIVE_HIGH>; interrupts = <TEGRA_GPIO(H, 4) IRQ_TYPE_LEVEL_HIGH>;
}; };
...@@ -88,7 +88,7 @@ rt5640 { ...@@ -88,7 +88,7 @@ rt5640 {
compatible = "realtek,rt5640"; compatible = "realtek,rt5640";
reg = <0x1c>; reg = <0x1c>;
interrupt-parent = <&gpio>; interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(W, 3) GPIO_ACTIVE_HIGH>; interrupts = <TEGRA_GPIO(W, 3) IRQ_TYPE_LEVEL_HIGH>;
realtek,ldo1-en-gpios = realtek,ldo1-en-gpios =
<&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>; <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
}; };
...@@ -72,7 +72,7 @@ rt5659 { ...@@ -72,7 +72,7 @@ rt5659 {
compatible = "realtek,rt5659"; compatible = "realtek,rt5659";
reg = <0x1b>; reg = <0x1b>;
interrupt-parent = <&gpio>; interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(W, 3) GPIO_ACTIVE_HIGH>; interrupts = <TEGRA_GPIO(W, 3) IRQ_TYPE_LEVEL_HIGH>;
realtek,ldo1-en-gpios = realtek,ldo1-en-gpios =
<&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>; <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
}; };
...@@ -62,7 +62,7 @@ rt5659 { ...@@ -62,7 +62,7 @@ rt5659 {
compatible = "realtek,rt5665"; compatible = "realtek,rt5665";
reg = <0x1b>; reg = <0x1b>;
interrupt-parent = <&gpio>; interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(W, 3) GPIO_ACTIVE_HIGH>; interrupts = <TEGRA_GPIO(W, 3) IRQ_TYPE_LEVEL_HIGH>;
realtek,ldo1-en-gpios = realtek,ldo1-en-gpios =
<&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>; <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
}; };
...@@ -41,7 +41,7 @@ rt5668 { ...@@ -41,7 +41,7 @@ rt5668 {
compatible = "realtek,rt5668b"; compatible = "realtek,rt5668b";
reg = <0x1a>; reg = <0x1a>;
interrupt-parent = <&gpio>; interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(U, 6) GPIO_ACTIVE_HIGH>; interrupts = <TEGRA_GPIO(U, 6) IRQ_TYPE_LEVEL_HIGH>;
realtek,ldo1-en-gpios = realtek,ldo1-en-gpios =
<&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_HIGH>; <&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
realtek,dmic1-data-pin = <1>; realtek,dmic1-data-pin = <1>;
......
...@@ -64,7 +64,7 @@ rt5677 { ...@@ -64,7 +64,7 @@ rt5677 {
compatible = "realtek,rt5677"; compatible = "realtek,rt5677";
reg = <0x2c>; reg = <0x2c>;
interrupt-parent = <&gpio>; interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(W, 3) GPIO_ACTIVE_HIGH>; interrupts = <TEGRA_GPIO(W, 3) IRQ_TYPE_LEVEL_HIGH>;
gpio-controller; gpio-controller;
#gpio-cells = <2>; #gpio-cells = <2>;
......
...@@ -58,7 +58,7 @@ rt5682 { ...@@ -58,7 +58,7 @@ rt5682 {
compatible = "realtek,rt5682i"; compatible = "realtek,rt5682i";
reg = <0x1a>; reg = <0x1a>;
interrupt-parent = <&gpio>; interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(U, 6) GPIO_ACTIVE_HIGH>; interrupts = <TEGRA_GPIO(U, 6) IRQ_TYPE_LEVEL_HIGH>;
realtek,ldo1-en-gpios = realtek,ldo1-en-gpios =
<&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_HIGH>; <&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
realtek,dmic1-data-pin = <1>; realtek,dmic1-data-pin = <1>;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment