Commit ac572452 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jacek Anaszewski

leds: mt6323: Fix an off by one bug in probe

It should be ">= MT6323_MAX_LEDS" instead of ">".  Also "reg" is a u32
so it can't be negative and we can remove the test for negative values.

Fixes: 216ec6cc ("leds: Add LED support for MT6323 PMIC")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
parent 6234004c
...@@ -417,7 +417,7 @@ static int mt6323_led_probe(struct platform_device *pdev) ...@@ -417,7 +417,7 @@ static int mt6323_led_probe(struct platform_device *pdev)
goto put_child_node; goto put_child_node;
} }
if (reg < 0 || reg > MT6323_MAX_LEDS || leds->led[reg]) { if (reg >= MT6323_MAX_LEDS || leds->led[reg]) {
dev_err(dev, "Invalid led reg %u\n", reg); dev_err(dev, "Invalid led reg %u\n", reg);
ret = -EINVAL; ret = -EINVAL;
goto put_child_node; goto put_child_node;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment