Commit ad401db6 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: remove thisboard macro in the ssv_dnp driver

The 'thisboard' macro depends on having a local variable with
a magic name. The CodingStyle document suggests not doing this
to avoid confusion. Remove the macro and use the comedi_board()
inline helper to get the dev->board_ptr information.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 42caa910
...@@ -59,9 +59,6 @@ struct dnp_board { ...@@ -59,9 +59,6 @@ struct dnp_board {
int have_dio; int have_dio;
}; };
/* Useful for shorthand access to the particular board structure ----------- */
#define thisboard ((const struct dnp_board *)dev->board_ptr)
/* This structure is for data unique to the DNP driver --------------------- */ /* This structure is for data unique to the DNP driver --------------------- */
struct dnp_private_data { struct dnp_private_data {
...@@ -188,18 +185,12 @@ static int dnp_dio_insn_config(struct comedi_device *dev, ...@@ -188,18 +185,12 @@ static int dnp_dio_insn_config(struct comedi_device *dev,
static int dnp_attach(struct comedi_device *dev, struct comedi_devconfig *it) static int dnp_attach(struct comedi_device *dev, struct comedi_devconfig *it)
{ {
const struct dnp_board *board = comedi_board(dev);
struct comedi_subdevice *s; struct comedi_subdevice *s;
printk(KERN_INFO "comedi%d: dnp: ", dev->minor); printk(KERN_INFO "comedi%d: dnp: ", dev->minor);
/* Autoprobing: this should find out which board we have. Currently */ dev->board_name = board->name;
/* only the 1486 board is supported and autoprobing is not */
/* implemented :-) */
/* dev->board_ptr = dnp_probe(dev); */
/* Initialize the name of the board. */
/* We can use the "thisboard" macro now. */
dev->board_name = thisboard->name;
/* Allocate the private structure area. alloc_private() is a */ /* Allocate the private structure area. alloc_private() is a */
/* convenient macro defined in comedidev.h. */ /* convenient macro defined in comedidev.h. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment