Commit adb260d1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

platform/x86: mlx-platform: free first dev on error

commit 63d762b8 upstream.

There is an off-by-one error so we don't unregister priv->pdev_mux[0].
Also it's slightly simpler as a while loop instead of a for loop.

Fixes: 58cbbee2 ("x86/platform/mellanox: Introduce support for Mellanox systems platform")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarVadim Pasternak <vadimp@mellanox.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 776050a9
......@@ -233,7 +233,7 @@ static int __init mlxplat_init(void)
return 0;
fail_platform_mux_register:
for (i--; i > 0 ; i--)
while (--i >= 0)
platform_device_unregister(priv->pdev_mux[i]);
platform_device_unregister(priv->pdev_i2c);
fail_alloc:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment