Commit add477df authored by Olivier Blin's avatar Olivier Blin Committed by Jeff Garzik

hso: fix oops in read/write callbacks

The tty may be closed already when the read/write callbacks are called.
This patch checks that the ttys still exist before waking them up.
Signed-off-by: default avatarOlivier Blin <blino@mandriva.com>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Cc: Jari Tenhunen <jari.tenhunen@iki.fi>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 1595ab5d
...@@ -1467,7 +1467,8 @@ static void hso_std_serial_write_bulk_callback(struct urb *urb) ...@@ -1467,7 +1467,8 @@ static void hso_std_serial_write_bulk_callback(struct urb *urb)
return; return;
} }
hso_put_activity(serial->parent); hso_put_activity(serial->parent);
tty_wakeup(serial->tty); if (serial->tty)
tty_wakeup(serial->tty);
hso_kick_transmit(serial); hso_kick_transmit(serial);
D1(" "); D1(" ");
...@@ -1538,7 +1539,8 @@ static void ctrl_callback(struct urb *urb) ...@@ -1538,7 +1539,8 @@ static void ctrl_callback(struct urb *urb)
clear_bit(HSO_SERIAL_FLAG_RX_SENT, &serial->flags); clear_bit(HSO_SERIAL_FLAG_RX_SENT, &serial->flags);
} else { } else {
hso_put_activity(serial->parent); hso_put_activity(serial->parent);
tty_wakeup(serial->tty); if (serial->tty)
tty_wakeup(serial->tty);
/* response to a write command */ /* response to a write command */
hso_kick_transmit(serial); hso_kick_transmit(serial);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment