Commit ae4aaf87 authored by Michael S. Tsirkin's avatar Michael S. Tsirkin Committed by Luis Henriques

virtio_pci: document why we defer kfree

commit a1eb03f5 upstream.

The reason we defer kfree until release function is because it's a
general rule for kobjects: kfree of the reference counter itself is only
legal in the release function.

Previous patch didn't make this clear, document this in code.
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
[ luis: backported to 3.16:
  - file rename: virtio_pci_legacy.c -> virtio_pci.c ]
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 29616921
...@@ -671,6 +671,9 @@ static void virtio_pci_release_dev(struct device *_d) ...@@ -671,6 +671,9 @@ static void virtio_pci_release_dev(struct device *_d)
struct virtio_device *vdev = dev_to_virtio(_d); struct virtio_device *vdev = dev_to_virtio(_d);
struct virtio_pci_device *vp_dev = to_vp_device(vdev); struct virtio_pci_device *vp_dev = to_vp_device(vdev);
/* As struct device is a kobject, it's not safe to
* free the memory (including the reference counter itself)
* until it's release callback. */
kfree(vp_dev); kfree(vp_dev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment