Commit aec9db35 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

6LoWPAN: use the _safe version of list_for_each

When we kfree(entry) that causes a use-after-free bug so we have to
use list_for_each_entry_safe() safe here.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 90d0963d
...@@ -813,15 +813,17 @@ static void lowpan_dellink(struct net_device *dev, struct list_head *head) ...@@ -813,15 +813,17 @@ static void lowpan_dellink(struct net_device *dev, struct list_head *head)
struct lowpan_dev_info *lowpan_dev = lowpan_dev_info(dev); struct lowpan_dev_info *lowpan_dev = lowpan_dev_info(dev);
struct net_device *real_dev = lowpan_dev->real_dev; struct net_device *real_dev = lowpan_dev->real_dev;
struct lowpan_dev_record *entry; struct lowpan_dev_record *entry;
struct lowpan_dev_record *tmp;
ASSERT_RTNL(); ASSERT_RTNL();
mutex_lock(&lowpan_dev_info(dev)->dev_list_mtx); mutex_lock(&lowpan_dev_info(dev)->dev_list_mtx);
list_for_each_entry(entry, &lowpan_devices, list) list_for_each_entry_safe(entry, tmp, &lowpan_devices, list) {
if (entry->ldev == dev) { if (entry->ldev == dev) {
list_del(&entry->list); list_del(&entry->list);
kfree(entry); kfree(entry);
} }
}
mutex_unlock(&lowpan_dev_info(dev)->dev_list_mtx); mutex_unlock(&lowpan_dev_info(dev)->dev_list_mtx);
mutex_destroy(&lowpan_dev_info(dev)->dev_list_mtx); mutex_destroy(&lowpan_dev_info(dev)->dev_list_mtx);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment