Skip to content

L
linux
Commit af4f7f38 authored by Nicolin Chen's avatar Nicolin Chen Committed by Mark Brown
Browse files
Options

ASoC: fsl_ssi: Refine indentations and wrappings 

This patch just simply unifies the coding style.
Signed-off-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
Tested-by: default avatarMaciej S. Szmigiero <mail@maciej.szmigiero.name>
Reviewed-by: default avatarMaciej S. Szmigiero <mail@maciej.szmigiero.name>
Acked-by: default avatarTimur Tabi <timur@tabi.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a818aa5f
Hide whitespace changes
Inline Side-by-side
Showing with 118 additions and 126 deletions
sound/soc/fsl/fsl_ssi.c
View file @ af4f7f38
...@@ -69,21 +69,35 @@ ...@@ -69,21 +69,35 @@
* samples will be written to STX properly. * samples will be written to STX properly.
*/ */
#ifdef __BIG_ENDIAN #ifdef __BIG_ENDIAN
#define FSLSSI_I2S_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_BE | \ #define FSLSSI_I2S_FORMATS \
SNDRV_PCM_FMTBIT_S18_3BE | SNDRV_PCM_FMTBIT_S20_3BE | \ (SNDRV_PCM_FMTBIT_S8 | \
SNDRV_PCM_FMTBIT_S24_3BE | SNDRV_PCM_FMTBIT_S24_BE) SNDRV_PCM_FMTBIT_S16_BE | \
SNDRV_PCM_FMTBIT_S18_3BE | \
SNDRV_PCM_FMTBIT_S20_3BE | \
SNDRV_PCM_FMTBIT_S24_3BE | \
SNDRV_PCM_FMTBIT_S24_BE)
#else #else
#define FSLSSI_I2S_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE | \ #define FSLSSI_I2S_FORMATS \
SNDRV_PCM_FMTBIT_S18_3LE | SNDRV_PCM_FMTBIT_S20_3LE | \ (SNDRV_PCM_FMTBIT_S8 | \
SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE) SNDRV_PCM_FMTBIT_S16_LE | \
SNDRV_PCM_FMTBIT_S18_3LE | \
SNDRV_PCM_FMTBIT_S20_3LE | \
SNDRV_PCM_FMTBIT_S24_3LE | \
SNDRV_PCM_FMTBIT_S24_LE)
#endif #endif
#define FSLSSI_SIER_DBG_RX_FLAGS (SSI_SIER_RFF0_EN | \ #define FSLSSI_SIER_DBG_RX_FLAGS \
SSI_SIER_RLS_EN | SSI_SIER_RFS_EN | \ (SSI_SIER_RFF0_EN | \
SSI_SIER_ROE0_EN | SSI_SIER_RFRC_EN) SSI_SIER_RLS_EN | \
#define FSLSSI_SIER_DBG_TX_FLAGS (SSI_SIER_TFE0_EN | \ SSI_SIER_RFS_EN | \
SSI_SIER_TLS_EN | SSI_SIER_TFS_EN | \ SSI_SIER_ROE0_EN | \
SSI_SIER_TUE0_EN | SSI_SIER_TFRC_EN) SSI_SIER_RFRC_EN)
#define FSLSSI_SIER_DBG_TX_FLAGS \
(SSI_SIER_TFE0_EN | \
SSI_SIER_TLS_EN | \
SSI_SIER_TFS_EN | \
SSI_SIER_TUE0_EN | \
SSI_SIER_TFRC_EN)
enum fsl_ssi_type { enum fsl_ssi_type {
FSL_SSI_MCP8610, FSL_SSI_MCP8610,
...@@ -291,8 +305,8 @@ static struct fsl_ssi_soc_data fsl_ssi_mpc8610 = { ...@@ -291,8 +305,8 @@ static struct fsl_ssi_soc_data fsl_ssi_mpc8610 = {
.imx = false, .imx = false,
.offline_config = true, .offline_config = true,
.sisr_write_mask = SSI_SISR_RFRC | SSI_SISR_TFRC | .sisr_write_mask = SSI_SISR_RFRC | SSI_SISR_TFRC |
SSI_SISR_ROE0 | SSI_SISR_ROE1 | SSI_SISR_ROE0 | SSI_SISR_ROE1 |
SSI_SISR_TUE0 | SSI_SISR_TUE1, SSI_SISR_TUE0 | SSI_SISR_TUE1,
}; };
static struct fsl_ssi_soc_data fsl_ssi_imx21 = { static struct fsl_ssi_soc_data fsl_ssi_imx21 = {
...@@ -306,15 +320,15 @@ static struct fsl_ssi_soc_data fsl_ssi_imx35 = { ...@@ -306,15 +320,15 @@ static struct fsl_ssi_soc_data fsl_ssi_imx35 = {
.imx = true, .imx = true,
.offline_config = true, .offline_config = true,
.sisr_write_mask = SSI_SISR_RFRC | SSI_SISR_TFRC | .sisr_write_mask = SSI_SISR_RFRC | SSI_SISR_TFRC |
SSI_SISR_ROE0 | SSI_SISR_ROE1 | SSI_SISR_ROE0 | SSI_SISR_ROE1 |
SSI_SISR_TUE0 | SSI_SISR_TUE1, SSI_SISR_TUE0 | SSI_SISR_TUE1,
}; };
static struct fsl_ssi_soc_data fsl_ssi_imx51 = { static struct fsl_ssi_soc_data fsl_ssi_imx51 = {
.imx = true, .imx = true,
.offline_config = false, .offline_config = false,
.sisr_write_mask = SSI_SISR_ROE0 | SSI_SISR_ROE1 | .sisr_write_mask = SSI_SISR_ROE0 | SSI_SISR_ROE1 |
SSI_SISR_TUE0 | SSI_SISR_TUE1, SSI_SISR_TUE0 | SSI_SISR_TUE1,
}; };
static const struct of_device_id fsl_ssi_ids[] = { static const struct of_device_id fsl_ssi_ids[] = {
...@@ -376,21 +390,21 @@ static void fsl_ssi_rxtx_config(struct fsl_ssi *ssi, bool enable) ...@@ -376,21 +390,21 @@ static void fsl_ssi_rxtx_config(struct fsl_ssi *ssi, bool enable)
if (enable) { if (enable) {
regmap_update_bits(regs, REG_SSI_SIER, regmap_update_bits(regs, REG_SSI_SIER,
vals->rx.sier | vals->tx.sier, vals->rx.sier | vals->tx.sier,
vals->rx.sier | vals->tx.sier); vals->rx.sier | vals->tx.sier);
regmap_update_bits(regs, REG_SSI_SRCR, regmap_update_bits(regs, REG_SSI_SRCR,
vals->rx.srcr | vals->tx.srcr, vals->rx.srcr | vals->tx.srcr,
vals->rx.srcr | vals->tx.srcr); vals->rx.srcr | vals->tx.srcr);
regmap_update_bits(regs, REG_SSI_STCR, regmap_update_bits(regs, REG_SSI_STCR,
vals->rx.stcr | vals->tx.stcr, vals->rx.stcr | vals->tx.stcr,
vals->rx.stcr | vals->tx.stcr); vals->rx.stcr | vals->tx.stcr);
} else { } else {
regmap_update_bits(regs, REG_SSI_SRCR, regmap_update_bits(regs, REG_SSI_SRCR,
vals->rx.srcr | vals->tx.srcr, 0); vals->rx.srcr | vals->tx.srcr, 0);
regmap_update_bits(regs, REG_SSI_STCR, regmap_update_bits(regs, REG_SSI_STCR,
vals->rx.stcr | vals->tx.stcr, 0); vals->rx.stcr | vals->tx.stcr, 0);
regmap_update_bits(regs, REG_SSI_SIER, regmap_update_bits(regs, REG_SSI_SIER,
vals->rx.sier | vals->tx.sier, 0); vals->rx.sier | vals->tx.sier, 0);
} }
} }
...@@ -401,10 +415,10 @@ static void fsl_ssi_fifo_clear(struct fsl_ssi *ssi, bool is_rx) ...@@ -401,10 +415,10 @@ static void fsl_ssi_fifo_clear(struct fsl_ssi *ssi, bool is_rx)
{ {
if (is_rx) { if (is_rx) {
regmap_update_bits(ssi->regs, REG_SSI_SOR, regmap_update_bits(ssi->regs, REG_SSI_SOR,
SSI_SOR_RX_CLR, SSI_SOR_RX_CLR); SSI_SOR_RX_CLR, SSI_SOR_RX_CLR);
} else { } else {
regmap_update_bits(ssi->regs, REG_SSI_SOR, regmap_update_bits(ssi->regs, REG_SSI_SOR,
SSI_SOR_TX_CLR, SSI_SOR_TX_CLR); SSI_SOR_TX_CLR, SSI_SOR_TX_CLR);
} }
} }
...@@ -432,7 +446,7 @@ static void fsl_ssi_fifo_clear(struct fsl_ssi *ssi, bool is_rx) ...@@ -432,7 +446,7 @@ static void fsl_ssi_fifo_clear(struct fsl_ssi *ssi, bool is_rx)
* Enable or disable SSI configuration. * Enable or disable SSI configuration.
*/ */
static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable,
struct fsl_ssi_reg_val *vals) struct fsl_ssi_reg_val *vals)
{ {
struct regmap *regs = ssi->regs; struct regmap *regs = ssi->regs;
struct fsl_ssi_reg_val *avals; struct fsl_ssi_reg_val *avals;
...@@ -442,8 +456,7 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, ...@@ -442,8 +456,7 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable,
regmap_read(regs, REG_SSI_SCR, &scr_val); regmap_read(regs, REG_SSI_SCR, &scr_val);
nr_active_streams = !!(scr_val & SSI_SCR_TE) + nr_active_streams = !!(scr_val & SSI_SCR_TE) + !!(scr_val & SSI_SCR_RE);
!!(scr_val & SSI_SCR_RE);
if (nr_active_streams - 1 > 0) if (nr_active_streams - 1 > 0)
keep_active = 1; keep_active = 1;
...@@ -462,7 +475,7 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, ...@@ -462,7 +475,7 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable,
* both streams, and get safe bits to disable current stream * both streams, and get safe bits to disable current stream
*/ */
u32 scr = fsl_ssi_disable_val(vals->scr, avals->scr, u32 scr = fsl_ssi_disable_val(vals->scr, avals->scr,
keep_active); keep_active);
/* Safely disable SCR register for the stream */ /* Safely disable SCR register for the stream */
regmap_update_bits(regs, REG_SSI_SCR, scr, 0); regmap_update_bits(regs, REG_SSI_SCR, scr, 0);
} }
...@@ -474,8 +487,7 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, ...@@ -474,8 +487,7 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable,
* 2) Disable all remaining bits of both streams when last stream ends * 2) Disable all remaining bits of both streams when last stream ends
*/ */
if (ssi->soc->offline_config) { if (ssi->soc->offline_config) {
if ((enable && !nr_active_streams) || if ((enable && !nr_active_streams) || (!enable && !keep_active))
(!enable && !keep_active))
fsl_ssi_rxtx_config(ssi, enable); fsl_ssi_rxtx_config(ssi, enable);
goto config_done; goto config_done;
...@@ -498,11 +510,11 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, ...@@ -498,11 +510,11 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable,
* both streams, and get safe bits to disable current stream * both streams, and get safe bits to disable current stream
*/ */
sier = fsl_ssi_disable_val(vals->sier, avals->sier, sier = fsl_ssi_disable_val(vals->sier, avals->sier,
keep_active); keep_active);
srcr = fsl_ssi_disable_val(vals->srcr, avals->srcr, srcr = fsl_ssi_disable_val(vals->srcr, avals->srcr,
keep_active); keep_active);
stcr = fsl_ssi_disable_val(vals->stcr, avals->stcr, stcr = fsl_ssi_disable_val(vals->stcr, avals->stcr,
keep_active); keep_active);
/* Safely disable other control registers for the stream */ /* Safely disable other control registers for the stream */
regmap_update_bits(regs, REG_SSI_SRCR, srcr, 0); regmap_update_bits(regs, REG_SSI_SRCR, srcr, 0);
...@@ -525,7 +537,7 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, ...@@ -525,7 +537,7 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable,
/* Enable SSI first to send TX DMA request */ /* Enable SSI first to send TX DMA request */
regmap_update_bits(regs, REG_SSI_SCR, regmap_update_bits(regs, REG_SSI_SCR,
SSI_SCR_SSIEN, SSI_SCR_SSIEN); SSI_SCR_SSIEN, SSI_SCR_SSIEN);
/* Busy wait until TX FIFO not empty -- DMA working */ /* Busy wait until TX FIFO not empty -- DMA working */
for (i = 0; i < max_loop; i++) { for (i = 0; i < max_loop; i++) {
...@@ -544,7 +556,6 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable, ...@@ -544,7 +556,6 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool enable,
} }
} }
static void fsl_ssi_rx_config(struct fsl_ssi *ssi, bool enable) static void fsl_ssi_rx_config(struct fsl_ssi *ssi, bool enable)
{ {
fsl_ssi_config(ssi, enable, &ssi->rxtx_reg_val.rx); fsl_ssi_config(ssi, enable, &ssi->rxtx_reg_val.rx);
...@@ -615,19 +626,16 @@ static void fsl_ssi_setup_ac97(struct fsl_ssi *ssi) ...@@ -615,19 +626,16 @@ static void fsl_ssi_setup_ac97(struct fsl_ssi *ssi)
struct regmap *regs = ssi->regs; struct regmap *regs = ssi->regs;
/* Setup the clock control register */ /* Setup the clock control register */
regmap_write(regs, REG_SSI_STCCR, regmap_write(regs, REG_SSI_STCCR, SSI_SxCCR_WL(17) | SSI_SxCCR_DC(13));
SSI_SxCCR_WL(17) | SSI_SxCCR_DC(13)); regmap_write(regs, REG_SSI_SRCCR, SSI_SxCCR_WL(17) | SSI_SxCCR_DC(13));
regmap_write(regs, REG_SSI_SRCCR,
SSI_SxCCR_WL(17) | SSI_SxCCR_DC(13));
/* Enable AC97 mode and startup the SSI */ /* Enable AC97 mode and startup the SSI */
regmap_write(regs, REG_SSI_SACNT, regmap_write(regs, REG_SSI_SACNT, SSI_SACNT_AC97EN | SSI_SACNT_FV);
SSI_SACNT_AC97EN | SSI_SACNT_FV);
/* AC97 has to communicate with codec before starting a stream */ /* AC97 has to communicate with codec before starting a stream */
regmap_update_bits(regs, REG_SSI_SCR, regmap_update_bits(regs, REG_SSI_SCR,
SSI_SCR_SSIEN | SSI_SCR_TE | SSI_SCR_RE, SSI_SCR_SSIEN | SSI_SCR_TE | SSI_SCR_RE,
SSI_SCR_SSIEN | SSI_SCR_TE | SSI_SCR_RE); SSI_SCR_SSIEN | SSI_SCR_TE | SSI_SCR_RE);
regmap_write(regs, REG_SSI_SOR, SSI_SOR_WAIT(3)); regmap_write(regs, REG_SSI_SOR, SSI_SOR_WAIT(3));
} }
...@@ -651,19 +659,18 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream, ...@@ -651,19 +659,18 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream,
*/ */
if (ssi->use_dual_fifo) if (ssi->use_dual_fifo)
snd_pcm_hw_constraint_step(substream->runtime, 0, snd_pcm_hw_constraint_step(substream->runtime, 0,
SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 2); SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 2);
return 0; return 0;
} }
static void fsl_ssi_shutdown(struct snd_pcm_substream *substream, static void fsl_ssi_shutdown(struct snd_pcm_substream *substream,
struct snd_soc_dai *dai) struct snd_soc_dai *dai)
{ {
struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(rtd->cpu_dai); struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(rtd->cpu_dai);
clk_disable_unprepare(ssi->clk); clk_disable_unprepare(ssi->clk);
} }
/** /**
...@@ -676,8 +683,8 @@ static void fsl_ssi_shutdown(struct snd_pcm_substream *substream, ...@@ -676,8 +683,8 @@ static void fsl_ssi_shutdown(struct snd_pcm_substream *substream,
* (In 2-channel I2S Master mode, slot_width is fixed 32) * (In 2-channel I2S Master mode, slot_width is fixed 32)
*/ */
static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream, static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream,
struct snd_soc_dai *cpu_dai, struct snd_soc_dai *cpu_dai,
struct snd_pcm_hw_params *hw_params) struct snd_pcm_hw_params *hw_params)
{ {
struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(cpu_dai); struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(cpu_dai);
struct regmap *regs = ssi->regs; struct regmap *regs = ssi->regs;
...@@ -764,8 +771,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream, ...@@ -764,8 +771,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream,
stccr = SSI_SxCCR_PM(pm + 1) | (div2 ? SSI_SxCCR_DIV2 : 0) | stccr = SSI_SxCCR_PM(pm + 1) | (div2 ? SSI_SxCCR_DIV2 : 0) |
(psr ? SSI_SxCCR_PSR : 0); (psr ? SSI_SxCCR_PSR : 0);
mask = SSI_SxCCR_PM_MASK | SSI_SxCCR_DIV2 | mask = SSI_SxCCR_PM_MASK | SSI_SxCCR_DIV2 | SSI_SxCCR_PSR;
SSI_SxCCR_PSR;
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK || synchronous) if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK || synchronous)
regmap_update_bits(regs, REG_SSI_STCCR, mask, stccr); regmap_update_bits(regs, REG_SSI_STCCR, mask, stccr);
...@@ -795,7 +801,8 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream, ...@@ -795,7 +801,8 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream,
* fsl_ssi_set_bclk() if SSI is the DAI clock master. * fsl_ssi_set_bclk() if SSI is the DAI clock master.
*/ */
static int fsl_ssi_hw_params(struct snd_pcm_substream *substream, static int fsl_ssi_hw_params(struct snd_pcm_substream *substream,
struct snd_pcm_hw_params *hw_params, struct snd_soc_dai *cpu_dai) struct snd_pcm_hw_params *hw_params,
struct snd_soc_dai *cpu_dai)
{ {
struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(cpu_dai); struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(cpu_dai);
struct regmap *regs = ssi->regs; struct regmap *regs = ssi->regs;
...@@ -837,36 +844,33 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream, ...@@ -837,36 +844,33 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream,
u8 i2smode; u8 i2smode;
/* Normal + Network mode to send 16-bit data in 32-bit frames */ /* Normal + Network mode to send 16-bit data in 32-bit frames */
if (fsl_ssi_is_i2s_cbm_cfs(ssi) && sample_size == 16) if (fsl_ssi_is_i2s_cbm_cfs(ssi) && sample_size == 16)
i2smode = SSI_SCR_I2S_MODE_NORMAL | i2smode = SSI_SCR_I2S_MODE_NORMAL | SSI_SCR_NET;
SSI_SCR_NET;
else else
i2smode = ssi->i2s_mode; i2smode = ssi->i2s_mode;
regmap_update_bits(regs, REG_SSI_SCR, regmap_update_bits(regs, REG_SSI_SCR,
SSI_SCR_NET | SSI_SCR_I2S_MODE_MASK, SSI_SCR_NET | SSI_SCR_I2S_MODE_MASK,
channels == 1 ? 0 : i2smode); channels == 1 ? 0 : i2smode);
} }
/* In synchronous mode, the SSI uses STCCR for capture */ /* In synchronous mode, the SSI uses STCCR for capture */
if ((substream->stream == SNDRV_PCM_STREAM_PLAYBACK) || if ((substream->stream == SNDRV_PCM_STREAM_PLAYBACK) ||
ssi->cpu_dai_drv.symmetric_rates) ssi->cpu_dai_drv.symmetric_rates)
regmap_update_bits(regs, REG_SSI_STCCR, SSI_SxCCR_WL_MASK, regmap_update_bits(regs, REG_SSI_STCCR, SSI_SxCCR_WL_MASK, wl);
wl);
else else
regmap_update_bits(regs, REG_SSI_SRCCR, SSI_SxCCR_WL_MASK, regmap_update_bits(regs, REG_SSI_SRCCR, SSI_SxCCR_WL_MASK, wl);
wl);
return 0; return 0;
} }
static int fsl_ssi_hw_free(struct snd_pcm_substream *substream, static int fsl_ssi_hw_free(struct snd_pcm_substream *substream,
struct snd_soc_dai *cpu_dai) struct snd_soc_dai *cpu_dai)
{ {
struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(rtd->cpu_dai); struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(rtd->cpu_dai);
if (fsl_ssi_is_i2s_master(ssi) && if (fsl_ssi_is_i2s_master(ssi) &&
ssi->baudclk_streams & BIT(substream->stream)) { ssi->baudclk_streams & BIT(substream->stream)) {
clk_disable_unprepare(ssi->baudclk); clk_disable_unprepare(ssi->baudclk);
ssi->baudclk_streams &= ~BIT(substream->stream); ssi->baudclk_streams &= ~BIT(substream->stream);
} }
...@@ -896,8 +900,7 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev, ...@@ -896,8 +900,7 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev,
scr |= SSI_SCR_SYNC_TX_FS; scr |= SSI_SCR_SYNC_TX_FS;
mask = SSI_STCR_TXBIT0 | SSI_STCR_TFDIR | SSI_STCR_TXDIR | mask = SSI_STCR_TXBIT0 | SSI_STCR_TFDIR | SSI_STCR_TXDIR |
SSI_STCR_TSCKP | SSI_STCR_TFSI | SSI_STCR_TFSL | SSI_STCR_TSCKP | SSI_STCR_TFSI | SSI_STCR_TFSL | SSI_STCR_TEFS;
SSI_STCR_TEFS;
regmap_read(regs, REG_SSI_STCR, &stcr); regmap_read(regs, REG_SSI_STCR, &stcr);
regmap_read(regs, REG_SSI_SRCR, &srcr); regmap_read(regs, REG_SSI_SRCR, &srcr);
stcr &= ~mask; stcr &= ~mask;
...@@ -908,11 +911,9 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev, ...@@ -908,11 +911,9 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev,
switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
case SND_SOC_DAIFMT_I2S: case SND_SOC_DAIFMT_I2S:
regmap_update_bits(regs, REG_SSI_STCCR, regmap_update_bits(regs, REG_SSI_STCCR,
SSI_SxCCR_DC_MASK, SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2));
SSI_SxCCR_DC(2));
regmap_update_bits(regs, REG_SSI_SRCCR, regmap_update_bits(regs, REG_SSI_SRCCR,
SSI_SxCCR_DC_MASK, SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2));
SSI_SxCCR_DC(2));
switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
case SND_SOC_DAIFMT_CBM_CFS: case SND_SOC_DAIFMT_CBM_CFS:
case SND_SOC_DAIFMT_CBS_CFS: case SND_SOC_DAIFMT_CBS_CFS:
...@@ -927,7 +928,7 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev, ...@@ -927,7 +928,7 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev,
/* Data on rising edge of bclk, frame low, 1clk before data */ /* Data on rising edge of bclk, frame low, 1clk before data */
strcr |= SSI_STCR_TFSI | SSI_STCR_TSCKP | strcr |= SSI_STCR_TFSI | SSI_STCR_TSCKP |
SSI_STCR_TXBIT0 | SSI_STCR_TEFS; SSI_STCR_TXBIT0 | SSI_STCR_TEFS;
break; break;
case SND_SOC_DAIFMT_LEFT_J: case SND_SOC_DAIFMT_LEFT_J:
/* Data on rising edge of bclk, frame high */ /* Data on rising edge of bclk, frame high */
...@@ -936,12 +937,11 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev, ...@@ -936,12 +937,11 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev,
case SND_SOC_DAIFMT_DSP_A: case SND_SOC_DAIFMT_DSP_A:
/* Data on rising edge of bclk, frame high, 1clk before data */ /* Data on rising edge of bclk, frame high, 1clk before data */
strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP | strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP |
SSI_STCR_TXBIT0 | SSI_STCR_TEFS; SSI_STCR_TXBIT0 | SSI_STCR_TEFS;
break; break;
case SND_SOC_DAIFMT_DSP_B: case SND_SOC_DAIFMT_DSP_B:
/* Data on rising edge of bclk, frame high */ /* Data on rising edge of bclk, frame high */
strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP | strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP | SSI_STCR_TXBIT0;
SSI_STCR_TXBIT0;
break; break;
case SND_SOC_DAIFMT_AC97: case SND_SOC_DAIFMT_AC97:
/* Data on falling edge of bclk, frame high, 1clk before data */ /* Data on falling edge of bclk, frame high, 1clk before data */
...@@ -1012,23 +1012,22 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev, ...@@ -1012,23 +1012,22 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev,
wm = ssi->fifo_watermark; wm = ssi->fifo_watermark;
regmap_write(regs, REG_SSI_SFCSR, regmap_write(regs, REG_SSI_SFCSR,
SSI_SFCSR_TFWM0(wm) | SSI_SFCSR_RFWM0(wm) | SSI_SFCSR_TFWM0(wm) | SSI_SFCSR_RFWM0(wm) |
SSI_SFCSR_TFWM1(wm) | SSI_SFCSR_RFWM1(wm)); SSI_SFCSR_TFWM1(wm) | SSI_SFCSR_RFWM1(wm));
if (ssi->use_dual_fifo) { if (ssi->use_dual_fifo) {
regmap_update_bits(regs, REG_SSI_SRCR, SSI_SRCR_RFEN1, regmap_update_bits(regs, REG_SSI_SRCR,
SSI_SRCR_RFEN1); SSI_SRCR_RFEN1, SSI_SRCR_RFEN1);
regmap_update_bits(regs, REG_SSI_STCR, SSI_STCR_TFEN1, regmap_update_bits(regs, REG_SSI_STCR,
SSI_STCR_TFEN1); SSI_STCR_TFEN1, SSI_STCR_TFEN1);
regmap_update_bits(regs, REG_SSI_SCR, SSI_SCR_TCH_EN, regmap_update_bits(regs, REG_SSI_SCR,
SSI_SCR_TCH_EN); SSI_SCR_TCH_EN, SSI_SCR_TCH_EN);
} }
if ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_AC97) if ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_AC97)
fsl_ssi_setup_ac97(ssi); fsl_ssi_setup_ac97(ssi);
return 0; return 0;
} }
/** /**
...@@ -1049,7 +1048,7 @@ static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt) ...@@ -1049,7 +1048,7 @@ static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
* Set TDM slot number and slot width * Set TDM slot number and slot width
*/ */
static int fsl_ssi_set_dai_tdm_slot(struct snd_soc_dai *cpu_dai, u32 tx_mask, static int fsl_ssi_set_dai_tdm_slot(struct snd_soc_dai *cpu_dai, u32 tx_mask,
u32 rx_mask, int slots, int slot_width) u32 rx_mask, int slots, int slot_width)
{ {
struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(cpu_dai); struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(cpu_dai);
struct regmap *regs = ssi->regs; struct regmap *regs = ssi->regs;
...@@ -1069,17 +1068,16 @@ static int fsl_ssi_set_dai_tdm_slot(struct snd_soc_dai *cpu_dai, u32 tx_mask, ...@@ -1069,17 +1068,16 @@ static int fsl_ssi_set_dai_tdm_slot(struct snd_soc_dai *cpu_dai, u32 tx_mask,
return -EINVAL; return -EINVAL;
} }
regmap_update_bits(regs, REG_SSI_STCCR, SSI_SxCCR_DC_MASK, regmap_update_bits(regs, REG_SSI_STCCR,
SSI_SxCCR_DC(slots)); SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(slots));
regmap_update_bits(regs, REG_SSI_SRCCR, SSI_SxCCR_DC_MASK, regmap_update_bits(regs, REG_SSI_SRCCR,
SSI_SxCCR_DC(slots)); SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(slots));
/* Save SSIEN bit of the SCR register */ /* Save SSIEN bit of the SCR register */
regmap_read(regs, REG_SSI_SCR, &val); regmap_read(regs, REG_SSI_SCR, &val);
val &= SSI_SCR_SSIEN; val &= SSI_SCR_SSIEN;
/* Temporarily enable SSI to allow SxMSKs to be configurable */ /* Temporarily enable SSI to allow SxMSKs to be configurable */
regmap_update_bits(regs, REG_SSI_SCR, SSI_SCR_SSIEN, regmap_update_bits(regs, REG_SSI_SCR, SSI_SCR_SSIEN, SSI_SCR_SSIEN);
SSI_SCR_SSIEN);
regmap_write(regs, REG_SSI_STMSK, ~tx_mask); regmap_write(regs, REG_SSI_STMSK, ~tx_mask);
regmap_write(regs, REG_SSI_SRMSK, ~rx_mask); regmap_write(regs, REG_SSI_SRMSK, ~rx_mask);
...@@ -1153,13 +1151,13 @@ static int fsl_ssi_dai_probe(struct snd_soc_dai *dai) ...@@ -1153,13 +1151,13 @@ static int fsl_ssi_dai_probe(struct snd_soc_dai *dai)
} }
static const struct snd_soc_dai_ops fsl_ssi_dai_ops = { static const struct snd_soc_dai_ops fsl_ssi_dai_ops = {
.startup = fsl_ssi_startup, .startup = fsl_ssi_startup,
.shutdown = fsl_ssi_shutdown, .shutdown = fsl_ssi_shutdown,
.hw_params = fsl_ssi_hw_params, .hw_params = fsl_ssi_hw_params,
.hw_free = fsl_ssi_hw_free, .hw_free = fsl_ssi_hw_free,
.set_fmt = fsl_ssi_set_dai_fmt, .set_fmt = fsl_ssi_set_dai_fmt,
.set_tdm_slot = fsl_ssi_set_dai_tdm_slot, .set_tdm_slot = fsl_ssi_set_dai_tdm_slot,
.trigger = fsl_ssi_trigger, .trigger = fsl_ssi_trigger,
}; };
static struct snd_soc_dai_driver fsl_ssi_dai_template = { static struct snd_soc_dai_driver fsl_ssi_dai_template = {
...@@ -1182,7 +1180,7 @@ static struct snd_soc_dai_driver fsl_ssi_dai_template = { ...@@ -1182,7 +1180,7 @@ static struct snd_soc_dai_driver fsl_ssi_dai_template = {
}; };
static const struct snd_soc_component_driver fsl_ssi_component = { static const struct snd_soc_component_driver fsl_ssi_component = {
.name = "fsl-ssi", .name = "fsl-ssi",
}; };
static struct snd_soc_dai_driver fsl_ssi_ac97_dai = { static struct snd_soc_dai_driver fsl_ssi_ac97_dai = {
...@@ -1206,11 +1204,10 @@ static struct snd_soc_dai_driver fsl_ssi_ac97_dai = { ...@@ -1206,11 +1204,10 @@ static struct snd_soc_dai_driver fsl_ssi_ac97_dai = {
.ops = &fsl_ssi_dai_ops, .ops = &fsl_ssi_dai_ops,
}; };
static struct fsl_ssi *fsl_ac97_data; static struct fsl_ssi *fsl_ac97_data;
static void fsl_ssi_ac97_write(struct snd_ac97 *ac97, unsigned short reg, static void fsl_ssi_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
unsigned short val) unsigned short val)
{ {
struct regmap *regs = fsl_ac97_data->regs; struct regmap *regs = fsl_ac97_data->regs;
unsigned int lreg; unsigned int lreg;
...@@ -1235,8 +1232,8 @@ static void fsl_ssi_ac97_write(struct snd_ac97 *ac97, unsigned short reg, ...@@ -1235,8 +1232,8 @@ static void fsl_ssi_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
lval = val << 4; lval = val << 4;
regmap_write(regs, REG_SSI_SACDAT, lval); regmap_write(regs, REG_SSI_SACDAT, lval);
regmap_update_bits(regs, REG_SSI_SACNT, SSI_SACNT_RDWR_MASK, regmap_update_bits(regs, REG_SSI_SACNT,
SSI_SACNT_WR); SSI_SACNT_RDWR_MASK, SSI_SACNT_WR);
udelay(100); udelay(100);
clk_disable_unprepare(fsl_ac97_data->clk); clk_disable_unprepare(fsl_ac97_data->clk);
...@@ -1246,10 +1243,9 @@ static void fsl_ssi_ac97_write(struct snd_ac97 *ac97, unsigned short reg, ...@@ -1246,10 +1243,9 @@ static void fsl_ssi_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
} }
static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97, static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97,
unsigned short reg) unsigned short reg)
{ {
struct regmap *regs = fsl_ac97_data->regs; struct regmap *regs = fsl_ac97_data->regs;
unsigned short val = 0; unsigned short val = 0;
u32 reg_val; u32 reg_val;
unsigned int lreg; unsigned int lreg;
...@@ -1259,15 +1255,14 @@ static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97, ...@@ -1259,15 +1255,14 @@ static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97,
ret = clk_prepare_enable(fsl_ac97_data->clk); ret = clk_prepare_enable(fsl_ac97_data->clk);
if (ret) { if (ret) {
pr_err("ac97 read clk_prepare_enable failed: %d\n", pr_err("ac97 read clk_prepare_enable failed: %d\n", ret);
ret);
goto ret_unlock; goto ret_unlock;
} }
lreg = (reg & 0x7f) << 12; lreg = (reg & 0x7f) << 12;
regmap_write(regs, REG_SSI_SACADD, lreg); regmap_write(regs, REG_SSI_SACADD, lreg);
regmap_update_bits(regs, REG_SSI_SACNT, SSI_SACNT_RDWR_MASK, regmap_update_bits(regs, REG_SSI_SACNT,
SSI_SACNT_RD); SSI_SACNT_RDWR_MASK, SSI_SACNT_RD);
udelay(100); udelay(100);
...@@ -1282,8 +1277,8 @@ static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97, ...@@ -1282,8 +1277,8 @@ static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97,
} }
static struct snd_ac97_bus_ops fsl_ssi_ac97_ops = { static struct snd_ac97_bus_ops fsl_ssi_ac97_ops = {
.read = fsl_ssi_ac97_read, .read = fsl_ssi_ac97_read,
.write = fsl_ssi_ac97_write, .write = fsl_ssi_ac97_write,
}; };
/** /**
...@@ -1298,7 +1293,7 @@ static void make_lowercase(char *s) ...@@ -1298,7 +1293,7 @@ static void make_lowercase(char *s)
} }
static int fsl_ssi_imx_probe(struct platform_device *pdev, static int fsl_ssi_imx_probe(struct platform_device *pdev,
struct fsl_ssi *ssi, void __iomem *iomem) struct fsl_ssi *ssi, void __iomem *iomem)
{ {
struct device_node *np = pdev->dev.of_node; struct device_node *np = pdev->dev.of_node;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
...@@ -1370,14 +1365,13 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev, ...@@ -1370,14 +1365,13 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
return 0; return 0;
error_pcm: error_pcm:
if (!ssi->has_ipg_clk_name) if (!ssi->has_ipg_clk_name)
clk_disable_unprepare(ssi->clk); clk_disable_unprepare(ssi->clk);
return ret; return ret;
} }
static void fsl_ssi_imx_clean(struct platform_device *pdev, static void fsl_ssi_imx_clean(struct platform_device *pdev, struct fsl_ssi *ssi)
struct fsl_ssi *ssi)
{ {
if (!ssi->use_dma) if (!ssi->use_dma)
imx_pcm_fiq_exit(pdev); imx_pcm_fiq_exit(pdev);
...@@ -1422,8 +1416,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) ...@@ -1422,8 +1416,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
if (fsl_ssi_is_ac97(ssi)) { if (fsl_ssi_is_ac97(ssi)) {
memcpy(&ssi->cpu_dai_drv, &fsl_ssi_ac97_dai, memcpy(&ssi->cpu_dai_drv, &fsl_ssi_ac97_dai,
sizeof(fsl_ssi_ac97_dai)); sizeof(fsl_ssi_ac97_dai));
fsl_ac97_data = ssi; fsl_ac97_data = ssi;
} else { } else {
memcpy(&ssi->cpu_dai_drv, &fsl_ssi_dai_template, memcpy(&ssi->cpu_dai_drv, &fsl_ssi_dai_template,
...@@ -1582,8 +1575,8 @@ static int fsl_ssi_probe(struct platform_device *pdev) ...@@ -1582,8 +1575,8 @@ static int fsl_ssi_probe(struct platform_device *pdev)
goto error_sound_card; goto error_sound_card;
} }
ssi->pdev = platform_device_register_data(NULL, ssi->pdev = platform_device_register_data(NULL, "ac97-codec",
"ac97-codec", ssi_idx, NULL, 0); ssi_idx, NULL, 0);
if (IS_ERR(ssi->pdev)) { if (IS_ERR(ssi->pdev)) {
ret = PTR_ERR(ssi->pdev); ret = PTR_ERR(ssi->pdev);
dev_err(dev, dev_err(dev,
...@@ -1597,11 +1590,9 @@ static int fsl_ssi_probe(struct platform_device *pdev) ...@@ -1597,11 +1590,9 @@ static int fsl_ssi_probe(struct platform_device *pdev)
error_sound_card: error_sound_card:
fsl_ssi_debugfs_remove(&ssi->dbg_stats); fsl_ssi_debugfs_remove(&ssi->dbg_stats);
error_asoc_register: error_asoc_register:
if (fsl_ssi_is_ac97(ssi)) if (fsl_ssi_is_ac97(ssi))
snd_soc_set_ac97_ops(NULL); snd_soc_set_ac97_ops(NULL);
error_ac97_ops: error_ac97_ops:
if (fsl_ssi_is_ac97(ssi)) if (fsl_ssi_is_ac97(ssi))
mutex_destroy(&ssi->ac97_reg_lock); mutex_destroy(&ssi->ac97_reg_lock);
...@@ -1655,9 +1646,9 @@ static int fsl_ssi_resume(struct device *dev) ...@@ -1655,9 +1646,9 @@ static int fsl_ssi_resume(struct device *dev)
regcache_cache_only(regs, false); regcache_cache_only(regs, false);
regmap_update_bits(regs, REG_SSI_SFCSR, regmap_update_bits(regs, REG_SSI_SFCSR,
SSI_SFCSR_RFWM1_MASK | SSI_SFCSR_TFWM1_MASK | SSI_SFCSR_RFWM1_MASK | SSI_SFCSR_TFWM1_MASK |
SSI_SFCSR_RFWM0_MASK | SSI_SFCSR_TFWM0_MASK, SSI_SFCSR_RFWM0_MASK | SSI_SFCSR_TFWM0_MASK,
ssi->regcache_sfcsr); ssi->regcache_sfcsr);
regmap_write(regs, REG_SSI_SACNT, ssi->regcache_sacnt); regmap_write(regs, REG_SSI_SACNT, ssi->regcache_sacnt);
return regcache_sync(regs); return regcache_sync(regs);
......
sound/soc/fsl/fsl_ssi.h
View file @ af4f7f38
...@@ -310,7 +310,7 @@ static inline void fsl_ssi_dbg_isr(struct fsl_ssi_dbg *stats, u32 sisr) ...@@ -310,7 +310,7 @@ static inline void fsl_ssi_dbg_isr(struct fsl_ssi_dbg *stats, u32 sisr)
} }
static inline int fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg, static inline int fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg,
struct device *dev) struct device *dev)
{ {
return 0; return 0;
} }
......
sound/soc/fsl/fsl_ssi_dbg.c
View file @ af4f7f38
...@@ -147,7 +147,8 @@ int fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg, struct device *dev) ...@@ -147,7 +147,8 @@ int fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg, struct device *dev)
return -ENOMEM; return -ENOMEM;
ssi_dbg->dbg_stats = debugfs_create_file("stats", S_IRUGO, ssi_dbg->dbg_stats = debugfs_create_file("stats", S_IRUGO,
ssi_dbg->dbg_dir, ssi_dbg, &fsl_ssi_stats_ops); ssi_dbg->dbg_dir, ssi_dbg,
&fsl_ssi_stats_ops);
if (!ssi_dbg->dbg_stats) { if (!ssi_dbg->dbg_stats) {
debugfs_remove(ssi_dbg->dbg_dir); debugfs_remove(ssi_dbg->dbg_dir);
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7