Commit b0008625 authored by Bean Huo's avatar Bean Huo Committed by Martin K. Petersen
parent f273c54b
...@@ -4258,10 +4258,8 @@ int ufshcd_make_hba_operational(struct ufs_hba *hba) ...@@ -4258,10 +4258,8 @@ int ufshcd_make_hba_operational(struct ufs_hba *hba)
dev_err(hba->dev, dev_err(hba->dev,
"Host controller not ready to process requests"); "Host controller not ready to process requests");
err = -EIO; err = -EIO;
goto out;
} }
out:
return err; return err;
} }
EXPORT_SYMBOL_GPL(ufshcd_make_hba_operational); EXPORT_SYMBOL_GPL(ufshcd_make_hba_operational);
...@@ -5544,10 +5542,8 @@ static bool ufshcd_quirk_dl_nac_errors(struct ufs_hba *hba) ...@@ -5544,10 +5542,8 @@ static bool ufshcd_quirk_dl_nac_errors(struct ufs_hba *hba)
hba->saved_err &= ~UIC_ERROR; hba->saved_err &= ~UIC_ERROR;
/* clear NAC error */ /* clear NAC error */
hba->saved_uic_err &= ~UFSHCD_UIC_DL_NAC_RECEIVED_ERROR; hba->saved_uic_err &= ~UFSHCD_UIC_DL_NAC_RECEIVED_ERROR;
if (!hba->saved_uic_err) { if (!hba->saved_uic_err)
err_handling = false; err_handling = false;
goto out;
}
} }
out: out:
spin_unlock_irqrestore(hba->host->host_lock, flags); spin_unlock_irqrestore(hba->host->host_lock, flags);
...@@ -7714,12 +7710,10 @@ static int ufshcd_config_vreg(struct device *dev, ...@@ -7714,12 +7710,10 @@ static int ufshcd_config_vreg(struct device *dev,
if (vreg->min_uV && vreg->max_uV) { if (vreg->min_uV && vreg->max_uV) {
min_uV = on ? vreg->min_uV : 0; min_uV = on ? vreg->min_uV : 0;
ret = regulator_set_voltage(reg, min_uV, vreg->max_uV); ret = regulator_set_voltage(reg, min_uV, vreg->max_uV);
if (ret) { if (ret)
dev_err(dev, dev_err(dev,
"%s: %s set voltage failed, err=%d\n", "%s: %s set voltage failed, err=%d\n",
__func__, name, ret); __func__, name, ret);
goto out;
}
} }
} }
out: out:
...@@ -7782,8 +7776,6 @@ static int ufshcd_setup_vreg(struct ufs_hba *hba, bool on) ...@@ -7782,8 +7776,6 @@ static int ufshcd_setup_vreg(struct ufs_hba *hba, bool on)
goto out; goto out;
ret = ufshcd_toggle_vreg(dev, info->vccq2, on); ret = ufshcd_toggle_vreg(dev, info->vccq2, on);
if (ret)
goto out;
out: out:
if (ret) { if (ret) {
...@@ -7829,10 +7821,8 @@ static int ufshcd_init_vreg(struct ufs_hba *hba) ...@@ -7829,10 +7821,8 @@ static int ufshcd_init_vreg(struct ufs_hba *hba)
goto out; goto out;
ret = ufshcd_get_vreg(dev, info->vccq); ret = ufshcd_get_vreg(dev, info->vccq);
if (ret) if (!ret)
goto out; ret = ufshcd_get_vreg(dev, info->vccq2);
ret = ufshcd_get_vreg(dev, info->vccq2);
out: out:
return ret; return ret;
} }
...@@ -7976,12 +7966,7 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba) ...@@ -7976,12 +7966,7 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba)
err = ufshcd_vops_setup_regulators(hba, true); err = ufshcd_vops_setup_regulators(hba, true);
if (err) if (err)
goto out_exit; ufshcd_vops_exit(hba);
goto out;
out_exit:
ufshcd_vops_exit(hba);
out: out:
if (err) if (err)
dev_err(hba->dev, "%s: variant %s init failed err %d\n", dev_err(hba->dev, "%s: variant %s init failed err %d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment