Commit b0c6ce24 authored by Fabio Estevam's avatar Fabio Estevam Committed by David S. Miller

net: fec: Remove unneeded use of IS_ERR_VALUE() macro

There is no need to use the IS_ERR_VALUE() macro for checking
the return value from pm_runtime_* functions.

Just do a simple negative test instead.

The semantic patch that makes this change is available
in scripts/coccinelle/api/pm_runtime.cocci.
Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 140d8b33
...@@ -1779,7 +1779,7 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum) ...@@ -1779,7 +1779,7 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
int ret = 0; int ret = 0;
ret = pm_runtime_get_sync(dev); ret = pm_runtime_get_sync(dev);
if (IS_ERR_VALUE(ret)) if (ret < 0)
return ret; return ret;
fep->mii_timeout = 0; fep->mii_timeout = 0;
...@@ -1818,7 +1818,7 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, ...@@ -1818,7 +1818,7 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum,
int ret = 0; int ret = 0;
ret = pm_runtime_get_sync(dev); ret = pm_runtime_get_sync(dev);
if (IS_ERR_VALUE(ret)) if (ret < 0)
return ret; return ret;
fep->mii_timeout = 0; fep->mii_timeout = 0;
...@@ -2870,7 +2870,7 @@ fec_enet_open(struct net_device *ndev) ...@@ -2870,7 +2870,7 @@ fec_enet_open(struct net_device *ndev)
int ret; int ret;
ret = pm_runtime_get_sync(&fep->pdev->dev); ret = pm_runtime_get_sync(&fep->pdev->dev);
if (IS_ERR_VALUE(ret)) if (ret < 0)
return ret; return ret;
pinctrl_pm_select_default_state(&fep->pdev->dev); pinctrl_pm_select_default_state(&fep->pdev->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment