Commit b0f539de authored by Dave Chinner's avatar Dave Chinner Committed by Ben Myers

xfs: connect up write verifiers to new buffers

Metadata buffers that are read from disk have write verifiers
already attached to them, but newly allocated buffers do not. Add
appropriate write verifiers to all new metadata buffers.
Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarBen Myers <bpm@sgi.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent 612cfbfe
...@@ -465,14 +465,14 @@ xfs_agfl_verify( ...@@ -465,14 +465,14 @@ xfs_agfl_verify(
#endif #endif
} }
static void void
xfs_agfl_write_verify( xfs_agfl_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
xfs_agfl_verify(bp); xfs_agfl_verify(bp);
} }
void static void
xfs_agfl_read_verify( xfs_agfl_read_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
...@@ -2181,14 +2181,14 @@ xfs_agf_verify( ...@@ -2181,14 +2181,14 @@ xfs_agf_verify(
} }
} }
static void void
xfs_agf_write_verify( xfs_agf_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
xfs_agf_verify(bp); xfs_agf_verify(bp);
} }
void static void
xfs_agf_read_verify( xfs_agf_read_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
......
...@@ -231,4 +231,7 @@ xfs_alloc_get_rec( ...@@ -231,4 +231,7 @@ xfs_alloc_get_rec(
xfs_extlen_t *len, /* output: length of extent */ xfs_extlen_t *len, /* output: length of extent */
int *stat); /* output: success/failure */ int *stat); /* output: success/failure */
void xfs_agf_write_verify(struct xfs_buf *bp);
void xfs_agfl_write_verify(struct xfs_buf *bp);
#endif /* __XFS_ALLOC_H__ */ #endif /* __XFS_ALLOC_H__ */
...@@ -401,6 +401,7 @@ static const struct xfs_btree_ops xfs_allocbt_ops = { ...@@ -401,6 +401,7 @@ static const struct xfs_btree_ops xfs_allocbt_ops = {
.init_ptr_from_cur = xfs_allocbt_init_ptr_from_cur, .init_ptr_from_cur = xfs_allocbt_init_ptr_from_cur,
.key_diff = xfs_allocbt_key_diff, .key_diff = xfs_allocbt_key_diff,
.read_verify = xfs_allocbt_read_verify, .read_verify = xfs_allocbt_read_verify,
.write_verify = xfs_allocbt_write_verify,
#ifdef DEBUG #ifdef DEBUG
.keys_inorder = xfs_allocbt_keys_inorder, .keys_inorder = xfs_allocbt_keys_inorder,
.recs_inorder = xfs_allocbt_recs_inorder, .recs_inorder = xfs_allocbt_recs_inorder,
......
...@@ -924,7 +924,7 @@ xfs_attr_leaf_to_node(xfs_da_args_t *args) ...@@ -924,7 +924,7 @@ xfs_attr_leaf_to_node(xfs_da_args_t *args)
XFS_ATTR_FORK); XFS_ATTR_FORK);
if (error) if (error)
goto out; goto out;
ASSERT(bp2 != NULL); bp2->b_pre_io = bp1->b_pre_io;
memcpy(bp2->b_addr, bp1->b_addr, XFS_LBSIZE(dp->i_mount)); memcpy(bp2->b_addr, bp1->b_addr, XFS_LBSIZE(dp->i_mount));
bp1 = NULL; bp1 = NULL;
xfs_trans_log_buf(args->trans, bp2, 0, XFS_LBSIZE(dp->i_mount) - 1); xfs_trans_log_buf(args->trans, bp2, 0, XFS_LBSIZE(dp->i_mount) - 1);
...@@ -978,7 +978,7 @@ xfs_attr_leaf_create( ...@@ -978,7 +978,7 @@ xfs_attr_leaf_create(
XFS_ATTR_FORK); XFS_ATTR_FORK);
if (error) if (error)
return(error); return(error);
ASSERT(bp != NULL); bp->b_pre_io = xfs_attr_leaf_write_verify;
leaf = bp->b_addr; leaf = bp->b_addr;
memset((char *)leaf, 0, XFS_LBSIZE(dp->i_mount)); memset((char *)leaf, 0, XFS_LBSIZE(dp->i_mount));
hdr = &leaf->hdr; hdr = &leaf->hdr;
......
...@@ -3124,6 +3124,7 @@ xfs_bmap_extents_to_btree( ...@@ -3124,6 +3124,7 @@ xfs_bmap_extents_to_btree(
/* /*
* Fill in the child block. * Fill in the child block.
*/ */
abp->b_pre_io = xfs_bmbt_write_verify;
ablock = XFS_BUF_TO_BLOCK(abp); ablock = XFS_BUF_TO_BLOCK(abp);
ablock->bb_magic = cpu_to_be32(XFS_BMAP_MAGIC); ablock->bb_magic = cpu_to_be32(XFS_BMAP_MAGIC);
ablock->bb_level = 0; ablock->bb_level = 0;
...@@ -3270,6 +3271,7 @@ xfs_bmap_local_to_extents( ...@@ -3270,6 +3271,7 @@ xfs_bmap_local_to_extents(
ASSERT(args.len == 1); ASSERT(args.len == 1);
*firstblock = args.fsbno; *firstblock = args.fsbno;
bp = xfs_btree_get_bufl(args.mp, tp, args.fsbno, 0); bp = xfs_btree_get_bufl(args.mp, tp, args.fsbno, 0);
bp->b_pre_io = xfs_bmbt_write_verify;
memcpy(bp->b_addr, ifp->if_u1.if_data, ifp->if_bytes); memcpy(bp->b_addr, ifp->if_u1.if_data, ifp->if_bytes);
xfs_trans_log_buf(tp, bp, 0, ifp->if_bytes - 1); xfs_trans_log_buf(tp, bp, 0, ifp->if_bytes - 1);
xfs_bmap_forkoff_reset(args.mp, ip, whichfork); xfs_bmap_forkoff_reset(args.mp, ip, whichfork);
......
...@@ -749,7 +749,7 @@ xfs_bmbt_verify( ...@@ -749,7 +749,7 @@ xfs_bmbt_verify(
} }
} }
static void void
xfs_bmbt_write_verify( xfs_bmbt_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
...@@ -806,6 +806,7 @@ static const struct xfs_btree_ops xfs_bmbt_ops = { ...@@ -806,6 +806,7 @@ static const struct xfs_btree_ops xfs_bmbt_ops = {
.init_ptr_from_cur = xfs_bmbt_init_ptr_from_cur, .init_ptr_from_cur = xfs_bmbt_init_ptr_from_cur,
.key_diff = xfs_bmbt_key_diff, .key_diff = xfs_bmbt_key_diff,
.read_verify = xfs_bmbt_read_verify, .read_verify = xfs_bmbt_read_verify,
.write_verify = xfs_bmbt_write_verify,
#ifdef DEBUG #ifdef DEBUG
.keys_inorder = xfs_bmbt_keys_inorder, .keys_inorder = xfs_bmbt_keys_inorder,
.recs_inorder = xfs_bmbt_recs_inorder, .recs_inorder = xfs_bmbt_recs_inorder,
......
...@@ -233,6 +233,7 @@ extern int xfs_bmbt_get_maxrecs(struct xfs_btree_cur *, int level); ...@@ -233,6 +233,7 @@ extern int xfs_bmbt_get_maxrecs(struct xfs_btree_cur *, int level);
extern int xfs_bmdr_maxrecs(struct xfs_mount *, int blocklen, int leaf); extern int xfs_bmdr_maxrecs(struct xfs_mount *, int blocklen, int leaf);
extern int xfs_bmbt_maxrecs(struct xfs_mount *, int blocklen, int leaf); extern int xfs_bmbt_maxrecs(struct xfs_mount *, int blocklen, int leaf);
extern void xfs_bmbt_read_verify(struct xfs_buf *bp); extern void xfs_bmbt_read_verify(struct xfs_buf *bp);
extern void xfs_bmbt_write_verify(struct xfs_buf *bp);
extern struct xfs_btree_cur *xfs_bmbt_init_cursor(struct xfs_mount *, extern struct xfs_btree_cur *xfs_bmbt_init_cursor(struct xfs_mount *,
struct xfs_trans *, struct xfs_inode *, int); struct xfs_trans *, struct xfs_inode *, int);
......
...@@ -996,6 +996,7 @@ xfs_btree_get_buf_block( ...@@ -996,6 +996,7 @@ xfs_btree_get_buf_block(
if (!*bpp) if (!*bpp)
return ENOMEM; return ENOMEM;
(*bpp)->b_pre_io = cur->bc_ops->write_verify;
*block = XFS_BUF_TO_BLOCK(*bpp); *block = XFS_BUF_TO_BLOCK(*bpp);
return 0; return 0;
} }
......
...@@ -189,6 +189,8 @@ struct xfs_btree_ops { ...@@ -189,6 +189,8 @@ struct xfs_btree_ops {
union xfs_btree_key *key); union xfs_btree_key *key);
void (*read_verify)(struct xfs_buf *bp); void (*read_verify)(struct xfs_buf *bp);
void (*write_verify)(struct xfs_buf *bp);
#ifdef DEBUG #ifdef DEBUG
/* check that k1 is lower than k2 */ /* check that k1 is lower than k2 */
int (*keys_inorder)(struct xfs_btree_cur *cur, int (*keys_inorder)(struct xfs_btree_cur *cur,
......
...@@ -193,6 +193,7 @@ xfs_da_node_create(xfs_da_args_t *args, xfs_dablk_t blkno, int level, ...@@ -193,6 +193,7 @@ xfs_da_node_create(xfs_da_args_t *args, xfs_dablk_t blkno, int level,
xfs_trans_log_buf(tp, bp, xfs_trans_log_buf(tp, bp,
XFS_DA_LOGRANGE(node, &node->hdr, sizeof(node->hdr))); XFS_DA_LOGRANGE(node, &node->hdr, sizeof(node->hdr)));
bp->b_pre_io = xfs_da_node_write_verify;
*bpp = bp; *bpp = bp;
return(0); return(0);
} }
...@@ -392,6 +393,8 @@ xfs_da_root_split(xfs_da_state_t *state, xfs_da_state_blk_t *blk1, ...@@ -392,6 +393,8 @@ xfs_da_root_split(xfs_da_state_t *state, xfs_da_state_blk_t *blk1,
} }
memcpy(node, oldroot, size); memcpy(node, oldroot, size);
xfs_trans_log_buf(tp, bp, 0, size - 1); xfs_trans_log_buf(tp, bp, 0, size - 1);
bp->b_pre_io = blk1->bp->b_pre_io;
blk1->bp = bp; blk1->bp = bp;
blk1->blkno = blkno; blk1->blkno = blkno;
......
...@@ -1010,6 +1010,7 @@ xfs_dir2_leaf_to_block( ...@@ -1010,6 +1010,7 @@ xfs_dir2_leaf_to_block(
/* /*
* Start converting it to block form. * Start converting it to block form.
*/ */
dbp->b_pre_io = xfs_dir2_block_write_verify;
hdr->magic = cpu_to_be32(XFS_DIR2_BLOCK_MAGIC); hdr->magic = cpu_to_be32(XFS_DIR2_BLOCK_MAGIC);
needlog = 1; needlog = 1;
needscan = 0; needscan = 0;
...@@ -1139,6 +1140,7 @@ xfs_dir2_sf_to_block( ...@@ -1139,6 +1140,7 @@ xfs_dir2_sf_to_block(
kmem_free(sfp); kmem_free(sfp);
return error; return error;
} }
bp->b_pre_io = xfs_dir2_block_write_verify;
hdr = bp->b_addr; hdr = bp->b_addr;
hdr->magic = cpu_to_be32(XFS_DIR2_BLOCK_MAGIC); hdr->magic = cpu_to_be32(XFS_DIR2_BLOCK_MAGIC);
/* /*
......
...@@ -185,7 +185,7 @@ __xfs_dir2_data_check( ...@@ -185,7 +185,7 @@ __xfs_dir2_data_check(
return 0; return 0;
} }
void static void
xfs_dir2_data_verify( xfs_dir2_data_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
...@@ -202,14 +202,14 @@ xfs_dir2_data_verify( ...@@ -202,14 +202,14 @@ xfs_dir2_data_verify(
} }
} }
static void void
xfs_dir2_data_write_verify( xfs_dir2_data_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
xfs_dir2_data_verify(bp); xfs_dir2_data_verify(bp);
} }
void static void
xfs_dir2_data_read_verify( xfs_dir2_data_read_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
...@@ -482,10 +482,9 @@ xfs_dir2_data_init( ...@@ -482,10 +482,9 @@ xfs_dir2_data_init(
*/ */
error = xfs_da_get_buf(tp, dp, xfs_dir2_db_to_da(mp, blkno), -1, &bp, error = xfs_da_get_buf(tp, dp, xfs_dir2_db_to_da(mp, blkno), -1, &bp,
XFS_DATA_FORK); XFS_DATA_FORK);
if (error) { if (error)
return error; return error;
} bp->b_pre_io = xfs_dir2_data_write_verify;
ASSERT(bp != NULL);
/* /*
* Initialize the header. * Initialize the header.
......
...@@ -81,7 +81,7 @@ xfs_dir2_leaf1_read_verify( ...@@ -81,7 +81,7 @@ xfs_dir2_leaf1_read_verify(
xfs_buf_ioend(bp, 0); xfs_buf_ioend(bp, 0);
} }
static void void
xfs_dir2_leafn_write_verify( xfs_dir2_leafn_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
...@@ -198,6 +198,7 @@ xfs_dir2_block_to_leaf( ...@@ -198,6 +198,7 @@ xfs_dir2_block_to_leaf(
/* /*
* Fix up the block header, make it a data block. * Fix up the block header, make it a data block.
*/ */
dbp->b_pre_io = xfs_dir2_data_write_verify;
hdr->magic = cpu_to_be32(XFS_DIR2_DATA_MAGIC); hdr->magic = cpu_to_be32(XFS_DIR2_DATA_MAGIC);
if (needscan) if (needscan)
xfs_dir2_data_freescan(mp, hdr, &needlog); xfs_dir2_data_freescan(mp, hdr, &needlog);
...@@ -1243,15 +1244,14 @@ xfs_dir2_leaf_init( ...@@ -1243,15 +1244,14 @@ xfs_dir2_leaf_init(
* Get the buffer for the block. * Get the buffer for the block.
*/ */
error = xfs_da_get_buf(tp, dp, xfs_dir2_db_to_da(mp, bno), -1, &bp, error = xfs_da_get_buf(tp, dp, xfs_dir2_db_to_da(mp, bno), -1, &bp,
XFS_DATA_FORK); XFS_DATA_FORK);
if (error) { if (error)
return error; return error;
}
ASSERT(bp != NULL);
leaf = bp->b_addr;
/* /*
* Initialize the header. * Initialize the header.
*/ */
leaf = bp->b_addr;
leaf->hdr.info.magic = cpu_to_be16(magic); leaf->hdr.info.magic = cpu_to_be16(magic);
leaf->hdr.info.forw = 0; leaf->hdr.info.forw = 0;
leaf->hdr.info.back = 0; leaf->hdr.info.back = 0;
...@@ -1264,10 +1264,12 @@ xfs_dir2_leaf_init( ...@@ -1264,10 +1264,12 @@ xfs_dir2_leaf_init(
* the block. * the block.
*/ */
if (magic == XFS_DIR2_LEAF1_MAGIC) { if (magic == XFS_DIR2_LEAF1_MAGIC) {
bp->b_pre_io = xfs_dir2_leaf1_write_verify;
ltp = xfs_dir2_leaf_tail_p(mp, leaf); ltp = xfs_dir2_leaf_tail_p(mp, leaf);
ltp->bestcount = 0; ltp->bestcount = 0;
xfs_dir2_leaf_log_tail(tp, bp); xfs_dir2_leaf_log_tail(tp, bp);
} } else
bp->b_pre_io = xfs_dir2_leafn_write_verify;
*bpp = bp; *bpp = bp;
return 0; return 0;
} }
...@@ -1951,7 +1953,10 @@ xfs_dir2_node_to_leaf( ...@@ -1951,7 +1953,10 @@ xfs_dir2_node_to_leaf(
xfs_dir2_leaf_compact(args, lbp); xfs_dir2_leaf_compact(args, lbp);
else else
xfs_dir2_leaf_log_header(tp, lbp); xfs_dir2_leaf_log_header(tp, lbp);
lbp->b_pre_io = xfs_dir2_leaf1_write_verify;
leaf->hdr.info.magic = cpu_to_be16(XFS_DIR2_LEAF1_MAGIC); leaf->hdr.info.magic = cpu_to_be16(XFS_DIR2_LEAF1_MAGIC);
/* /*
* Set up the leaf tail from the freespace block. * Set up the leaf tail from the freespace block.
*/ */
......
...@@ -197,11 +197,12 @@ xfs_dir2_leaf_to_node( ...@@ -197,11 +197,12 @@ xfs_dir2_leaf_to_node(
/* /*
* Get the buffer for the new freespace block. * Get the buffer for the new freespace block.
*/ */
if ((error = xfs_da_get_buf(tp, dp, xfs_dir2_db_to_da(mp, fdb), -1, &fbp, error = xfs_da_get_buf(tp, dp, xfs_dir2_db_to_da(mp, fdb), -1, &fbp,
XFS_DATA_FORK))) { XFS_DATA_FORK);
if (error)
return error; return error;
} fbp->b_pre_io = xfs_dir2_free_write_verify;
ASSERT(fbp != NULL);
free = fbp->b_addr; free = fbp->b_addr;
leaf = lbp->b_addr; leaf = lbp->b_addr;
ltp = xfs_dir2_leaf_tail_p(mp, leaf); ltp = xfs_dir2_leaf_tail_p(mp, leaf);
...@@ -223,7 +224,10 @@ xfs_dir2_leaf_to_node( ...@@ -223,7 +224,10 @@ xfs_dir2_leaf_to_node(
*to = cpu_to_be16(off); *to = cpu_to_be16(off);
} }
free->hdr.nused = cpu_to_be32(n); free->hdr.nused = cpu_to_be32(n);
lbp->b_pre_io = xfs_dir2_leafn_write_verify;
leaf->hdr.info.magic = cpu_to_be16(XFS_DIR2_LEAFN_MAGIC); leaf->hdr.info.magic = cpu_to_be16(XFS_DIR2_LEAFN_MAGIC);
/* /*
* Log everything. * Log everything.
*/ */
...@@ -632,6 +636,7 @@ xfs_dir2_leafn_lookup_for_entry( ...@@ -632,6 +636,7 @@ xfs_dir2_leafn_lookup_for_entry(
state->extrablk.index = (int)((char *)dep - state->extrablk.index = (int)((char *)dep -
(char *)curbp->b_addr); (char *)curbp->b_addr);
state->extrablk.magic = XFS_DIR2_DATA_MAGIC; state->extrablk.magic = XFS_DIR2_DATA_MAGIC;
curbp->b_pre_io = xfs_dir2_data_write_verify;
if (cmp == XFS_CMP_EXACT) if (cmp == XFS_CMP_EXACT)
return XFS_ERROR(EEXIST); return XFS_ERROR(EEXIST);
} }
...@@ -646,6 +651,7 @@ xfs_dir2_leafn_lookup_for_entry( ...@@ -646,6 +651,7 @@ xfs_dir2_leafn_lookup_for_entry(
state->extrablk.index = -1; state->extrablk.index = -1;
state->extrablk.blkno = curdb; state->extrablk.blkno = curdb;
state->extrablk.magic = XFS_DIR2_DATA_MAGIC; state->extrablk.magic = XFS_DIR2_DATA_MAGIC;
curbp->b_pre_io = xfs_dir2_data_write_verify;
} else { } else {
/* If the curbp is not the CI match block, drop it */ /* If the curbp is not the CI match block, drop it */
if (state->extrablk.bp != curbp) if (state->extrablk.bp != curbp)
...@@ -1638,12 +1644,12 @@ xfs_dir2_node_addname_int( ...@@ -1638,12 +1644,12 @@ xfs_dir2_node_addname_int(
/* /*
* Get a buffer for the new block. * Get a buffer for the new block.
*/ */
if ((error = xfs_da_get_buf(tp, dp, error = xfs_da_get_buf(tp, dp,
xfs_dir2_db_to_da(mp, fbno), xfs_dir2_db_to_da(mp, fbno),
-1, &fbp, XFS_DATA_FORK))) { -1, &fbp, XFS_DATA_FORK);
if (error)
return error; return error;
} fbp->b_pre_io = xfs_dir2_free_write_verify;
ASSERT(fbp != NULL);
/* /*
* Initialize the new block to be empty, and remember * Initialize the new block to be empty, and remember
......
...@@ -45,6 +45,7 @@ extern int xfs_dir2_leaf_to_block(struct xfs_da_args *args, ...@@ -45,6 +45,7 @@ extern int xfs_dir2_leaf_to_block(struct xfs_da_args *args,
#else #else
#define xfs_dir2_data_check(dp,bp) #define xfs_dir2_data_check(dp,bp)
#endif #endif
extern void xfs_dir2_data_write_verify(struct xfs_buf *bp);
extern int __xfs_dir2_data_check(struct xfs_inode *dp, struct xfs_buf *bp); extern int __xfs_dir2_data_check(struct xfs_inode *dp, struct xfs_buf *bp);
extern int xfs_dir2_data_read(struct xfs_trans *tp, struct xfs_inode *dp, extern int xfs_dir2_data_read(struct xfs_trans *tp, struct xfs_inode *dp,
xfs_dablk_t bno, xfs_daddr_t mapped_bno, struct xfs_buf **bpp); xfs_dablk_t bno, xfs_daddr_t mapped_bno, struct xfs_buf **bpp);
...@@ -73,6 +74,7 @@ extern void xfs_dir2_data_use_free(struct xfs_trans *tp, struct xfs_buf *bp, ...@@ -73,6 +74,7 @@ extern void xfs_dir2_data_use_free(struct xfs_trans *tp, struct xfs_buf *bp,
/* xfs_dir2_leaf.c */ /* xfs_dir2_leaf.c */
extern void xfs_dir2_leafn_read_verify(struct xfs_buf *bp); extern void xfs_dir2_leafn_read_verify(struct xfs_buf *bp);
extern void xfs_dir2_leafn_write_verify(struct xfs_buf *bp);
extern int xfs_dir2_leafn_read(struct xfs_trans *tp, struct xfs_inode *dp, extern int xfs_dir2_leafn_read(struct xfs_trans *tp, struct xfs_inode *dp,
xfs_dablk_t fbno, xfs_daddr_t mappedbno, struct xfs_buf **bpp); xfs_dablk_t fbno, xfs_daddr_t mappedbno, struct xfs_buf **bpp);
extern int xfs_dir2_block_to_leaf(struct xfs_da_args *args, extern int xfs_dir2_block_to_leaf(struct xfs_da_args *args,
......
...@@ -248,7 +248,57 @@ xfs_qm_init_dquot_blk( ...@@ -248,7 +248,57 @@ xfs_qm_init_dquot_blk(
xfs_trans_log_buf(tp, bp, 0, BBTOB(q->qi_dqchunklen) - 1); xfs_trans_log_buf(tp, bp, 0, BBTOB(q->qi_dqchunklen) - 1);
} }
static void
xfs_dquot_buf_verify(
struct xfs_buf *bp)
{
struct xfs_mount *mp = bp->b_target->bt_mount;
struct xfs_dqblk *d = (struct xfs_dqblk *)bp->b_addr;
struct xfs_disk_dquot *ddq;
xfs_dqid_t id = 0;
int i;
/*
* On the first read of the buffer, verify that each dquot is valid.
* We don't know what the id of the dquot is supposed to be, just that
* they should be increasing monotonically within the buffer. If the
* first id is corrupt, then it will fail on the second dquot in the
* buffer so corruptions could point to the wrong dquot in this case.
*/
for (i = 0; i < mp->m_quotainfo->qi_dqperchunk; i++) {
int error;
ddq = &d[i].dd_diskdq;
if (i == 0)
id = be32_to_cpu(ddq->d_id);
error = xfs_qm_dqcheck(mp, ddq, id + i, 0, XFS_QMOPT_DOWARN,
"xfs_dquot_read_verify");
if (error) {
XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, d);
xfs_buf_ioerror(bp, EFSCORRUPTED);
break;
}
}
}
static void
xfs_dquot_buf_write_verify(
struct xfs_buf *bp)
{
xfs_dquot_buf_verify(bp);
}
void
xfs_dquot_buf_read_verify(
struct xfs_buf *bp)
{
xfs_dquot_buf_verify(bp);
bp->b_pre_io = xfs_dquot_buf_write_verify;
bp->b_iodone = NULL;
xfs_buf_ioend(bp, 0);
}
/* /*
* Allocate a block and fill it with dquots. * Allocate a block and fill it with dquots.
...@@ -315,6 +365,7 @@ xfs_qm_dqalloc( ...@@ -315,6 +365,7 @@ xfs_qm_dqalloc(
error = xfs_buf_geterror(bp); error = xfs_buf_geterror(bp);
if (error) if (error)
goto error1; goto error1;
bp->b_pre_io = xfs_dquot_buf_write_verify;
/* /*
* Make a chunk of dquots out of this buffer and log * Make a chunk of dquots out of this buffer and log
...@@ -359,59 +410,6 @@ xfs_qm_dqalloc( ...@@ -359,59 +410,6 @@ xfs_qm_dqalloc(
return (error); return (error);
} }
static void
xfs_dquot_buf_verify(
struct xfs_buf *bp)
{
struct xfs_mount *mp = bp->b_target->bt_mount;
struct xfs_dqblk *d = (struct xfs_dqblk *)bp->b_addr;
struct xfs_disk_dquot *ddq;
xfs_dqid_t id = 0;
int i;
/*
* On the first read of the buffer, verify that each dquot is valid.
* We don't know what the id of the dquot is supposed to be, just that
* they should be increasing monotonically within the buffer. If the
* first id is corrupt, then it will fail on the second dquot in the
* buffer so corruptions could point to the wrong dquot in this case.
*/
for (i = 0; i < mp->m_quotainfo->qi_dqperchunk; i++) {
int error;
ddq = &d[i].dd_diskdq;
if (i == 0)
id = be32_to_cpu(ddq->d_id);
error = xfs_qm_dqcheck(mp, ddq, id + i, 0, XFS_QMOPT_DOWARN,
"xfs_dquot_read_verify");
if (error) {
XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, d);
xfs_buf_ioerror(bp, EFSCORRUPTED);
break;
}
}
}
static void
xfs_dquot_buf_write_verify(
struct xfs_buf *bp)
{
xfs_dquot_buf_verify(bp);
}
void
xfs_dquot_buf_read_verify(
struct xfs_buf *bp)
{
xfs_dquot_buf_verify(bp);
bp->b_pre_io = xfs_dquot_buf_write_verify;
bp->b_iodone = NULL;
xfs_buf_ioend(bp, 0);
}
STATIC int STATIC int
xfs_qm_dqrepair( xfs_qm_dqrepair(
struct xfs_mount *mp, struct xfs_mount *mp,
......
...@@ -222,6 +222,7 @@ xfs_growfs_data_private( ...@@ -222,6 +222,7 @@ xfs_growfs_data_private(
error = ENOMEM; error = ENOMEM;
goto error0; goto error0;
} }
bp->b_pre_io = xfs_agf_write_verify;
agf = XFS_BUF_TO_AGF(bp); agf = XFS_BUF_TO_AGF(bp);
agf->agf_magicnum = cpu_to_be32(XFS_AGF_MAGIC); agf->agf_magicnum = cpu_to_be32(XFS_AGF_MAGIC);
...@@ -259,6 +260,7 @@ xfs_growfs_data_private( ...@@ -259,6 +260,7 @@ xfs_growfs_data_private(
error = ENOMEM; error = ENOMEM;
goto error0; goto error0;
} }
bp->b_pre_io = xfs_agfl_write_verify;
agfl = XFS_BUF_TO_AGFL(bp); agfl = XFS_BUF_TO_AGFL(bp);
for (bucket = 0; bucket < XFS_AGFL_SIZE(mp); bucket++) for (bucket = 0; bucket < XFS_AGFL_SIZE(mp); bucket++)
...@@ -279,6 +281,7 @@ xfs_growfs_data_private( ...@@ -279,6 +281,7 @@ xfs_growfs_data_private(
error = ENOMEM; error = ENOMEM;
goto error0; goto error0;
} }
bp->b_pre_io = xfs_agi_write_verify;
agi = XFS_BUF_TO_AGI(bp); agi = XFS_BUF_TO_AGI(bp);
agi->agi_magicnum = cpu_to_be32(XFS_AGI_MAGIC); agi->agi_magicnum = cpu_to_be32(XFS_AGI_MAGIC);
...@@ -450,9 +453,10 @@ xfs_growfs_data_private( ...@@ -450,9 +453,10 @@ xfs_growfs_data_private(
bp = xfs_trans_get_buf(NULL, mp->m_ddev_targp, bp = xfs_trans_get_buf(NULL, mp->m_ddev_targp,
XFS_AGB_TO_DADDR(mp, agno, XFS_SB_BLOCK(mp)), XFS_AGB_TO_DADDR(mp, agno, XFS_SB_BLOCK(mp)),
XFS_FSS_TO_BB(mp, 1), 0); XFS_FSS_TO_BB(mp, 1), 0);
if (bp) if (bp) {
xfs_buf_zero(bp, 0, BBTOB(bp->b_length)); xfs_buf_zero(bp, 0, BBTOB(bp->b_length));
else bp->b_pre_io = xfs_sb_write_verify;
} else
error = ENOMEM; error = ENOMEM;
} }
......
...@@ -210,6 +210,7 @@ xfs_ialloc_inode_init( ...@@ -210,6 +210,7 @@ xfs_ialloc_inode_init(
* to log a whole cluster of inodes instead of all the * to log a whole cluster of inodes instead of all the
* individual transactions causing a lot of log traffic. * individual transactions causing a lot of log traffic.
*/ */
fbuf->b_pre_io = xfs_inode_buf_write_verify;
xfs_buf_zero(fbuf, 0, ninodes << mp->m_sb.sb_inodelog); xfs_buf_zero(fbuf, 0, ninodes << mp->m_sb.sb_inodelog);
for (i = 0; i < ninodes; i++) { for (i = 0; i < ninodes; i++) {
int ioffset = i << mp->m_sb.sb_inodelog; int ioffset = i << mp->m_sb.sb_inodelog;
...@@ -1504,14 +1505,14 @@ xfs_agi_verify( ...@@ -1504,14 +1505,14 @@ xfs_agi_verify(
xfs_check_agi_unlinked(agi); xfs_check_agi_unlinked(agi);
} }
static void void
xfs_agi_write_verify( xfs_agi_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
xfs_agi_verify(bp); xfs_agi_verify(bp);
} }
void static void
xfs_agi_read_verify( xfs_agi_read_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
......
...@@ -147,7 +147,9 @@ int xfs_inobt_lookup(struct xfs_btree_cur *cur, xfs_agino_t ino, ...@@ -147,7 +147,9 @@ int xfs_inobt_lookup(struct xfs_btree_cur *cur, xfs_agino_t ino,
/* /*
* Get the data from the pointed-to record. * Get the data from the pointed-to record.
*/ */
extern int xfs_inobt_get_rec(struct xfs_btree_cur *cur, int xfs_inobt_get_rec(struct xfs_btree_cur *cur,
xfs_inobt_rec_incore_t *rec, int *stat); xfs_inobt_rec_incore_t *rec, int *stat);
void xfs_agi_write_verify(struct xfs_buf *bp);
#endif /* __XFS_IALLOC_H__ */ #endif /* __XFS_IALLOC_H__ */
...@@ -271,6 +271,7 @@ static const struct xfs_btree_ops xfs_inobt_ops = { ...@@ -271,6 +271,7 @@ static const struct xfs_btree_ops xfs_inobt_ops = {
.init_ptr_from_cur = xfs_inobt_init_ptr_from_cur, .init_ptr_from_cur = xfs_inobt_init_ptr_from_cur,
.key_diff = xfs_inobt_key_diff, .key_diff = xfs_inobt_key_diff,
.read_verify = xfs_inobt_read_verify, .read_verify = xfs_inobt_read_verify,
.write_verify = xfs_inobt_write_verify,
#ifdef DEBUG #ifdef DEBUG
.keys_inorder = xfs_inobt_keys_inorder, .keys_inorder = xfs_inobt_keys_inorder,
.recs_inorder = xfs_inobt_recs_inorder, .recs_inorder = xfs_inobt_recs_inorder,
......
...@@ -420,7 +420,7 @@ xfs_inode_buf_verify( ...@@ -420,7 +420,7 @@ xfs_inode_buf_verify(
xfs_inobp_check(mp, bp); xfs_inobp_check(mp, bp);
} }
static void void
xfs_inode_buf_write_verify( xfs_inode_buf_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
...@@ -1782,6 +1782,18 @@ xfs_ifree_cluster( ...@@ -1782,6 +1782,18 @@ xfs_ifree_cluster(
if (!bp) if (!bp)
return ENOMEM; return ENOMEM;
/*
* This buffer may not have been correctly initialised as we
* didn't read it from disk. That's not important because we are
* only using to mark the buffer as stale in the log, and to
* attach stale cached inodes on it. That means it will never be
* dispatched for IO. If it is, we want to know about it, and we
* want it to fail. We can acheive this by adding a write
* verifier to the buffer.
*/
bp->b_pre_io = xfs_inode_buf_write_verify;
/* /*
* Walk the inodes already attached to the buffer and mark them * Walk the inodes already attached to the buffer and mark them
* stale. These will all have the flush locks held, so an * stale. These will all have the flush locks held, so an
......
...@@ -555,6 +555,7 @@ int xfs_imap_to_bp(struct xfs_mount *, struct xfs_trans *, ...@@ -555,6 +555,7 @@ int xfs_imap_to_bp(struct xfs_mount *, struct xfs_trans *,
int xfs_iread(struct xfs_mount *, struct xfs_trans *, int xfs_iread(struct xfs_mount *, struct xfs_trans *,
struct xfs_inode *, uint); struct xfs_inode *, uint);
void xfs_inode_buf_read_verify(struct xfs_buf *); void xfs_inode_buf_read_verify(struct xfs_buf *);
void xfs_inode_buf_write_verify(struct xfs_buf *);
void xfs_dinode_to_disk(struct xfs_dinode *, void xfs_dinode_to_disk(struct xfs_dinode *,
struct xfs_icdinode *); struct xfs_icdinode *);
void xfs_idestroy_fork(struct xfs_inode *, int); void xfs_idestroy_fork(struct xfs_inode *, int);
......
...@@ -631,7 +631,7 @@ xfs_sb_verify( ...@@ -631,7 +631,7 @@ xfs_sb_verify(
xfs_buf_ioerror(bp, error); xfs_buf_ioerror(bp, error);
} }
static void void
xfs_sb_write_verify( xfs_sb_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
......
...@@ -386,6 +386,7 @@ extern void xfs_set_low_space_thresholds(struct xfs_mount *); ...@@ -386,6 +386,7 @@ extern void xfs_set_low_space_thresholds(struct xfs_mount *);
#endif /* __KERNEL__ */ #endif /* __KERNEL__ */
extern void xfs_sb_read_verify(struct xfs_buf *); extern void xfs_sb_read_verify(struct xfs_buf *);
extern void xfs_sb_write_verify(struct xfs_buf *bp);
extern void xfs_mod_sb(struct xfs_trans *, __int64_t); extern void xfs_mod_sb(struct xfs_trans *, __int64_t);
extern int xfs_initialize_perag(struct xfs_mount *, xfs_agnumber_t, extern int xfs_initialize_perag(struct xfs_mount *, xfs_agnumber_t,
xfs_agnumber_t *); xfs_agnumber_t *);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment