Commit b14ed2c2 authored by Richard Weinberger's avatar Richard Weinberger Committed by Ingo Molnar

sched: Fix sched_policy < 0 comparison

attr.sched_policy is u32, therefore a comparison against < 0 is never true.
Fix this by casting sched_policy to int.

This issue was reported by coverity CID 1219934.

Fixes: dbdb2275 ("sched: Disallow sched_attr::sched_policy < 0")
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1401741514-7045-1-git-send-email-richard@nod.atSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent e9dd685c
...@@ -3685,7 +3685,7 @@ SYSCALL_DEFINE3(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr, ...@@ -3685,7 +3685,7 @@ SYSCALL_DEFINE3(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr,
if (retval) if (retval)
return retval; return retval;
if (attr.sched_policy < 0) if ((int)attr.sched_policy < 0)
return -EINVAL; return -EINVAL;
rcu_read_lock(); rcu_read_lock();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment