Commit b19e2ca7 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman

TTY: use tty_port_link_device

So now for those drivers that can use neither tty_port_install nor
tty_port_register_driver but still have tty_port available before
tty_register_driver we use newly added tty_port_link_device.

The rest of the drivers that still do not provide tty_struct <->
tty_port link will have to be converted to implement
tty->ops->install.
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Acked-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2cb4ca02
...@@ -223,6 +223,7 @@ srmcons_init(void) ...@@ -223,6 +223,7 @@ srmcons_init(void)
driver->subtype = SYSTEM_TYPE_SYSCONS; driver->subtype = SYSTEM_TYPE_SYSCONS;
driver->init_termios = tty_std_termios; driver->init_termios = tty_std_termios;
tty_set_operations(driver, &srmcons_ops); tty_set_operations(driver, &srmcons_ops);
tty_port_link_device(&srmcons_singleton.port, driver, 0);
err = tty_register_driver(driver); err = tty_register_driver(driver);
if (err) { if (err) {
put_tty_driver(driver); put_tty_driver(driver);
......
...@@ -545,6 +545,7 @@ static int __init simrs_init(void) ...@@ -545,6 +545,7 @@ static int __init simrs_init(void)
/* the port is imaginary */ /* the port is imaginary */
printk(KERN_INFO "ttyS0 at 0x03f8 (irq = %d) is a 16550\n", state->irq); printk(KERN_INFO "ttyS0 at 0x03f8 (irq = %d) is a 16550\n", state->irq);
tty_port_link_device(&state->port, hp_simserial_driver, 0);
retval = tty_register_driver(hp_simserial_driver); retval = tty_register_driver(hp_simserial_driver);
if (retval) { if (retval) {
printk(KERN_ERR "Couldn't register simserial driver\n"); printk(KERN_ERR "Couldn't register simserial driver\n");
......
...@@ -202,6 +202,7 @@ static int __init pdc_console_tty_driver_init(void) ...@@ -202,6 +202,7 @@ static int __init pdc_console_tty_driver_init(void)
pdc_console_tty_driver->flags = TTY_DRIVER_REAL_RAW | pdc_console_tty_driver->flags = TTY_DRIVER_REAL_RAW |
TTY_DRIVER_RESET_TERMIOS; TTY_DRIVER_RESET_TERMIOS;
tty_set_operations(pdc_console_tty_driver, &pdc_console_tty_ops); tty_set_operations(pdc_console_tty_driver, &pdc_console_tty_ops);
tty_port_link_device(&tty_port, pdc_console_tty_driver, 0);
err = tty_register_driver(pdc_console_tty_driver); err = tty_register_driver(pdc_console_tty_driver);
if (err) { if (err) {
......
...@@ -223,6 +223,7 @@ int __init rs_init(void) ...@@ -223,6 +223,7 @@ int __init rs_init(void)
serial_driver->flags = TTY_DRIVER_REAL_RAW; serial_driver->flags = TTY_DRIVER_REAL_RAW;
tty_set_operations(serial_driver, &serial_ops); tty_set_operations(serial_driver, &serial_ops);
tty_port_link_device(&serial_port, serial_driver, 0);
if (tty_register_driver(serial_driver)) if (tty_register_driver(serial_driver))
panic("Couldn't register serial driver\n"); panic("Couldn't register serial driver\n");
......
...@@ -198,6 +198,7 @@ static int __init ttyprintk_init(void) ...@@ -198,6 +198,7 @@ static int __init ttyprintk_init(void)
ttyprintk_driver->init_termios = tty_std_termios; ttyprintk_driver->init_termios = tty_std_termios;
ttyprintk_driver->init_termios.c_oflag = OPOST | OCRNL | ONOCR | ONLRET; ttyprintk_driver->init_termios.c_oflag = OPOST | OCRNL | ONOCR | ONLRET;
tty_set_operations(ttyprintk_driver, &ttyprintk_ops); tty_set_operations(ttyprintk_driver, &ttyprintk_ops);
tty_port_link_device(&tpk_port.port, ttyprintk_driver, 0);
ret = tty_register_driver(ttyprintk_driver); ret = tty_register_driver(ttyprintk_driver);
if (ret < 0) { if (ret < 0) {
......
...@@ -567,6 +567,7 @@ sclp_tty_init(void) ...@@ -567,6 +567,7 @@ sclp_tty_init(void)
driver->init_termios.c_lflag = ISIG | ECHO; driver->init_termios.c_lflag = ISIG | ECHO;
driver->flags = TTY_DRIVER_REAL_RAW; driver->flags = TTY_DRIVER_REAL_RAW;
tty_set_operations(driver, &sclp_ops); tty_set_operations(driver, &sclp_ops);
tty_port_link_device(&sclp_port, driver, 0);
rc = tty_register_driver(driver); rc = tty_register_driver(driver);
if (rc) { if (rc) {
put_tty_driver(driver); put_tty_driver(driver);
......
...@@ -691,6 +691,7 @@ static int __init sclp_vt220_tty_init(void) ...@@ -691,6 +691,7 @@ static int __init sclp_vt220_tty_init(void)
driver->init_termios = tty_std_termios; driver->init_termios = tty_std_termios;
driver->flags = TTY_DRIVER_REAL_RAW; driver->flags = TTY_DRIVER_REAL_RAW;
tty_set_operations(driver, &sclp_vt220_ops); tty_set_operations(driver, &sclp_vt220_ops);
tty_port_link_device(&sclp_vt220_port, driver, 0);
rc = tty_register_driver(driver); rc = tty_register_driver(driver);
if (rc) if (rc)
......
...@@ -1710,10 +1710,6 @@ static int __init amiga_serial_probe(struct platform_device *pdev) ...@@ -1710,10 +1710,6 @@ static int __init amiga_serial_probe(struct platform_device *pdev)
serial_driver->flags = TTY_DRIVER_REAL_RAW; serial_driver->flags = TTY_DRIVER_REAL_RAW;
tty_set_operations(serial_driver, &serial_ops); tty_set_operations(serial_driver, &serial_ops);
error = tty_register_driver(serial_driver);
if (error)
goto fail_put_tty_driver;
state = rs_table; state = rs_table;
state->port = (int)&custom.serdatr; /* Just to give it a value */ state->port = (int)&custom.serdatr; /* Just to give it a value */
state->custom_divisor = 0; state->custom_divisor = 0;
...@@ -1724,6 +1720,11 @@ static int __init amiga_serial_probe(struct platform_device *pdev) ...@@ -1724,6 +1720,11 @@ static int __init amiga_serial_probe(struct platform_device *pdev)
state->icount.overrun = state->icount.brk = 0; state->icount.overrun = state->icount.brk = 0;
tty_port_init(&state->tport); tty_port_init(&state->tport);
state->tport.ops = &amiga_port_ops; state->tport.ops = &amiga_port_ops;
tty_port_link_device(&state->tport, serial_driver, 0);
error = tty_register_driver(serial_driver);
if (error)
goto fail_put_tty_driver;
printk(KERN_INFO "ttyS0 is the amiga builtin serial port\n"); printk(KERN_INFO "ttyS0 is the amiga builtin serial port\n");
......
...@@ -263,6 +263,7 @@ static int __init bfin_jc_init(void) ...@@ -263,6 +263,7 @@ static int __init bfin_jc_init(void)
bfin_jc_driver->subtype = SERIAL_TYPE_NORMAL; bfin_jc_driver->subtype = SERIAL_TYPE_NORMAL;
bfin_jc_driver->init_termios = tty_std_termios; bfin_jc_driver->init_termios = tty_std_termios;
tty_set_operations(bfin_jc_driver, &bfin_jc_ops); tty_set_operations(bfin_jc_driver, &bfin_jc_ops);
tty_port_link_device(&port, bfin_jc_driver, 0);
ret = tty_register_driver(bfin_jc_driver); ret = tty_register_driver(bfin_jc_driver);
if (ret) if (ret)
......
...@@ -1080,6 +1080,8 @@ static int __init hvsi_init(void) ...@@ -1080,6 +1080,8 @@ static int __init hvsi_init(void)
struct hvsi_struct *hp = &hvsi_ports[i]; struct hvsi_struct *hp = &hvsi_ports[i];
int ret = 1; int ret = 1;
tty_port_link_device(&hp->port, hvsi_driver, i);
ret = request_irq(hp->virq, hvsi_interrupt, 0, "hvsi", hp); ret = request_irq(hp->virq, hvsi_interrupt, 0, "hvsi", hp);
if (ret) if (ret)
printk(KERN_ERR "HVSI: couldn't reserve irq 0x%x (error %i)\n", printk(KERN_ERR "HVSI: couldn't reserve irq 0x%x (error %i)\n",
......
...@@ -1189,12 +1189,6 @@ rs68328_init(void) ...@@ -1189,12 +1189,6 @@ rs68328_init(void)
serial_driver->flags = TTY_DRIVER_REAL_RAW; serial_driver->flags = TTY_DRIVER_REAL_RAW;
tty_set_operations(serial_driver, &rs_ops); tty_set_operations(serial_driver, &rs_ops);
if (tty_register_driver(serial_driver)) {
put_tty_driver(serial_driver);
printk(KERN_ERR "Couldn't register serial driver\n");
return -ENOMEM;
}
local_irq_save(flags); local_irq_save(flags);
for(i=0;i<NR_PORTS;i++) { for(i=0;i<NR_PORTS;i++) {
...@@ -1224,8 +1218,17 @@ rs68328_init(void) ...@@ -1224,8 +1218,17 @@ rs68328_init(void)
0, 0,
"M68328_UART", info)) "M68328_UART", info))
panic("Unable to attach 68328 serial interrupt\n"); panic("Unable to attach 68328 serial interrupt\n");
tty_port_link_device(&info->tport, serial_driver, i);
} }
local_irq_restore(flags); local_irq_restore(flags);
if (tty_register_driver(serial_driver)) {
put_tty_driver(serial_driver);
printk(KERN_ERR "Couldn't register serial driver\n");
return -ENOMEM;
}
return 0; return 0;
} }
......
...@@ -4447,10 +4447,8 @@ static int __init rs_init(void) ...@@ -4447,10 +4447,8 @@ static int __init rs_init(void)
tty_set_operations(driver, &rs_ops); tty_set_operations(driver, &rs_ops);
serial_driver = driver; serial_driver = driver;
if (tty_register_driver(driver))
panic("Couldn't register serial driver\n");
/* do some initializing for the separate ports */
/* do some initializing for the separate ports */
for (i = 0, info = rs_table; i < NR_PORTS; i++,info++) { for (i = 0, info = rs_table; i < NR_PORTS; i++,info++) {
if (info->enabled) { if (info->enabled) {
if (cris_request_io_interface(info->io_if, if (cris_request_io_interface(info->io_if,
...@@ -4502,7 +4500,12 @@ static int __init rs_init(void) ...@@ -4502,7 +4500,12 @@ static int __init rs_init(void)
printk(KERN_INFO "%s%d at %p is a builtin UART with DMA\n", printk(KERN_INFO "%s%d at %p is a builtin UART with DMA\n",
serial_driver->name, info->line, info->ioport); serial_driver->name, info->line, info->ioport);
} }
tty_port_link_device(&info->port, driver, i);
} }
if (tty_register_driver(driver))
panic("Couldn't register serial driver\n");
#ifdef CONFIG_ETRAX_FAST_TIMER #ifdef CONFIG_ETRAX_FAST_TIMER
#ifdef CONFIG_ETRAX_SERIAL_FAST_TIMER #ifdef CONFIG_ETRAX_SERIAL_FAST_TIMER
memset(fast_timers, 0, sizeof(fast_timers)); memset(fast_timers, 0, sizeof(fast_timers));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment