Commit b2c74237 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'for-5.3/dm-fixes-1' of...

Merge tag 'for-5.3/dm-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

Pull device mapper fixes from Mike Snitzer:
 "Fix NULL pointer and various whitespace issues with DM's recent DAX
  code changes from commit in 5.3 merge"

* tag 'for-5.3/dm-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm:
  dm table: fix various whitespace issues with recent DAX code
  dm table: fix dax_dev NULL dereference in device_synchronous()
parents b07042ca 9c50a98f
...@@ -882,23 +882,23 @@ EXPORT_SYMBOL_GPL(dm_table_set_type); ...@@ -882,23 +882,23 @@ EXPORT_SYMBOL_GPL(dm_table_set_type);
/* validate the dax capability of the target device span */ /* validate the dax capability of the target device span */
int device_supports_dax(struct dm_target *ti, struct dm_dev *dev, int device_supports_dax(struct dm_target *ti, struct dm_dev *dev,
sector_t start, sector_t len, void *data) sector_t start, sector_t len, void *data)
{ {
int blocksize = *(int *) data; int blocksize = *(int *) data;
return generic_fsdax_supported(dev->dax_dev, dev->bdev, blocksize, return generic_fsdax_supported(dev->dax_dev, dev->bdev, blocksize,
start, len); start, len);
} }
/* Check devices support synchronous DAX */ /* Check devices support synchronous DAX */
static int device_synchronous(struct dm_target *ti, struct dm_dev *dev, static int device_dax_synchronous(struct dm_target *ti, struct dm_dev *dev,
sector_t start, sector_t len, void *data) sector_t start, sector_t len, void *data)
{ {
return dax_synchronous(dev->dax_dev); return dev->dax_dev && dax_synchronous(dev->dax_dev);
} }
bool dm_table_supports_dax(struct dm_table *t, bool dm_table_supports_dax(struct dm_table *t,
iterate_devices_callout_fn iterate_fn, int *blocksize) iterate_devices_callout_fn iterate_fn, int *blocksize)
{ {
struct dm_target *ti; struct dm_target *ti;
unsigned i; unsigned i;
...@@ -911,7 +911,7 @@ bool dm_table_supports_dax(struct dm_table *t, ...@@ -911,7 +911,7 @@ bool dm_table_supports_dax(struct dm_table *t,
return false; return false;
if (!ti->type->iterate_devices || if (!ti->type->iterate_devices ||
!ti->type->iterate_devices(ti, iterate_fn, blocksize)) !ti->type->iterate_devices(ti, iterate_fn, blocksize))
return false; return false;
} }
...@@ -1921,7 +1921,7 @@ void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q, ...@@ -1921,7 +1921,7 @@ void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
if (dm_table_supports_dax(t, device_supports_dax, &page_size)) { if (dm_table_supports_dax(t, device_supports_dax, &page_size)) {
blk_queue_flag_set(QUEUE_FLAG_DAX, q); blk_queue_flag_set(QUEUE_FLAG_DAX, q);
if (dm_table_supports_dax(t, device_synchronous, NULL)) if (dm_table_supports_dax(t, device_dax_synchronous, NULL))
set_dax_synchronous(t->md->dax_dev); set_dax_synchronous(t->md->dax_dev);
} }
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment