Commit b2c78cd0 authored by Theodore Ts'o's avatar Theodore Ts'o

ext4: "ret" may be used uninitialized in ext4_lazyinit_thread()

Newer GCC's reported the following build warning:

   fs/ext4/super.c: In function 'ext4_lazyinit_thread':
   fs/ext4/super.c:2702: warning: 'ret' may be used uninitialized in this function

Fix it by removing the need for the ret variable in the first place.
Signed-off-by: default avatar"Lukas Czerner" <lczerner@redhat.com>
Reported-by: default avatar"Stefan Richter" <stefanr@s5r6.in-berlin.de>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent f4245bd4
...@@ -2699,7 +2699,6 @@ static int ext4_lazyinit_thread(void *arg) ...@@ -2699,7 +2699,6 @@ static int ext4_lazyinit_thread(void *arg)
struct ext4_li_request *elr; struct ext4_li_request *elr;
unsigned long next_wakeup; unsigned long next_wakeup;
DEFINE_WAIT(wait); DEFINE_WAIT(wait);
int ret;
BUG_ON(NULL == eli); BUG_ON(NULL == eli);
...@@ -2723,13 +2722,12 @@ static int ext4_lazyinit_thread(void *arg) ...@@ -2723,13 +2722,12 @@ static int ext4_lazyinit_thread(void *arg)
elr = list_entry(pos, struct ext4_li_request, elr = list_entry(pos, struct ext4_li_request,
lr_request); lr_request);
if (time_after_eq(jiffies, elr->lr_next_sched)) if (time_after_eq(jiffies, elr->lr_next_sched)) {
ret = ext4_run_li_request(elr); if (ext4_run_li_request(elr) != 0) {
/* error, remove the lazy_init job */
if (ret) { ext4_remove_li_request(elr);
ret = 0; continue;
ext4_remove_li_request(elr); }
continue;
} }
if (time_before(elr->lr_next_sched, next_wakeup)) if (time_before(elr->lr_next_sched, next_wakeup))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment