Commit b383836d authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Herbert Xu

hwrng: ingenic - Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 9daec3cb
...@@ -114,15 +114,13 @@ static int ingenic_rng_probe(struct platform_device *pdev) ...@@ -114,15 +114,13 @@ static int ingenic_rng_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int ingenic_rng_remove(struct platform_device *pdev) static void ingenic_rng_remove(struct platform_device *pdev)
{ {
struct ingenic_rng *priv = platform_get_drvdata(pdev); struct ingenic_rng *priv = platform_get_drvdata(pdev);
hwrng_unregister(&priv->rng); hwrng_unregister(&priv->rng);
writel(0, priv->base + RNG_REG_ERNG_OFFSET); writel(0, priv->base + RNG_REG_ERNG_OFFSET);
return 0;
} }
static const struct of_device_id ingenic_rng_of_match[] = { static const struct of_device_id ingenic_rng_of_match[] = {
...@@ -134,7 +132,7 @@ MODULE_DEVICE_TABLE(of, ingenic_rng_of_match); ...@@ -134,7 +132,7 @@ MODULE_DEVICE_TABLE(of, ingenic_rng_of_match);
static struct platform_driver ingenic_rng_driver = { static struct platform_driver ingenic_rng_driver = {
.probe = ingenic_rng_probe, .probe = ingenic_rng_probe,
.remove = ingenic_rng_remove, .remove_new = ingenic_rng_remove,
.driver = { .driver = {
.name = "ingenic-rng", .name = "ingenic-rng",
.of_match_table = ingenic_rng_of_match, .of_match_table = ingenic_rng_of_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment