Commit b3d0f789 authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by Theodore Ts'o

net/neighbor: use get_random_u32 for 32-bit hash random

Using get_random_u32 here is faster, more fitting of the use case, and
just as cryptographically secure. It also has the benefit of providing
better randomness at early boot, which is when many of these structures
are assigned.
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent d48ad080
...@@ -312,8 +312,7 @@ static struct neighbour *neigh_alloc(struct neigh_table *tbl, struct net_device ...@@ -312,8 +312,7 @@ static struct neighbour *neigh_alloc(struct neigh_table *tbl, struct net_device
static void neigh_get_hash_rnd(u32 *x) static void neigh_get_hash_rnd(u32 *x)
{ {
get_random_bytes(x, sizeof(*x)); *x = get_random_u32() | 1;
*x |= 1;
} }
static struct neigh_hash_table *neigh_hash_alloc(unsigned int shift) static struct neigh_hash_table *neigh_hash_alloc(unsigned int shift)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment