Commit b3f3db9c authored by Adam Sampson's avatar Adam Sampson Committed by Maxime Ripard

ARM: dts: sun7i: Correct USB regulators on pcDuino v3 Nano

The LinkSprite pcDuino v3 Nano's two USB host ports are powered by a
single RT9701GB regulator, which has its enable input tied to the A20's
PD2 pin, pulled up to 3v3 via a 10k resistor.

However, the script.bin that shipped with the device listed PH11 and PH3
as Vbus control pins for the two USB ports. Neither of these are
actually connected to anything.

Siarhei Siamashka spotted this problem while reviewing the other
LinkSprite boards. This patch fixes it by only defining a single
regulator, controlled by PD2. Testing shows that the USB ports are now
(correctly) only powered up once the USB PHY driver is loaded.
Reported-by: default avatarSiarhei Siamashka <siarhei.siamashka@gmail.com>
Signed-off-by: default avatarAdam Sampson <ats@offog.org>
Reviewed-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
parent eeea0fa3
......@@ -158,7 +158,7 @@ led_pins_pcduino3_nano: led_pins@0 {
};
usb1_vbus_pin_pcduino3_nano: usb1_vbus_pin@0 {
allwinner,pins = "PH11";
allwinner,pins = "PD2";
allwinner,function = "gpio_out";
allwinner,drive = <SUN4I_PINCTRL_10_MA>;
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
......@@ -171,13 +171,10 @@ &reg_ahci_5v {
status = "okay";
};
/* A single regulator (U24) powers both USB host ports. */
&reg_usb1_vbus {
pinctrl-0 = <&usb1_vbus_pin_pcduino3_nano>;
gpio = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */
status = "okay";
};
&reg_usb2_vbus {
gpio = <&pio 3 2 GPIO_ACTIVE_HIGH>; /* PD2 */
status = "okay";
};
......@@ -189,6 +186,6 @@ &uart0 {
&usbphy {
usb1_vbus-supply = <&reg_usb1_vbus>;
usb2_vbus-supply = <&reg_usb2_vbus>;
usb2_vbus-supply = <&reg_usb1_vbus>;
status = "okay";
};
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment