Commit b5effd38 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar

debug: Fix __bug_table[] in arch linker scripts

The kbuild test robot reported this build failure on a number
of architectures:

 >         make.cross ARCH=arm
 >    lib/lib.a(bug.o): In function `find_bug':
 > >> lib/bug.c:135: undefined reference to `__start___bug_table'
 > >> lib/bug.c:135: undefined reference to `__stop___bug_table'

Caused by:

  19d43626 ("debug: Add _ONCE() logic to report_bug()")

Which moved the BUG_TABLE from RO_DATA_SECTION() to RW_DATA_SECTION(),
but a number of architectures don't use RW_DATA_SECTION(), so they
ended up with no __bug_table[] ...

Ideally all those would use RW_DATA_SECTION() in their linker scripts,
but that's for another day.
Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org
Cc: tipbuild@zytor.com
Link: http://lkml.kernel.org/r/20170330154927.o6qmgfp4bdhrajbm@hirez.programming.kicks-ass.netSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 19d43626
...@@ -242,6 +242,8 @@ SECTIONS ...@@ -242,6 +242,8 @@ SECTIONS
} }
_edata_loc = __data_loc + SIZEOF(.data); _edata_loc = __data_loc + SIZEOF(.data);
BUG_TABLE
#ifdef CONFIG_HAVE_TCM #ifdef CONFIG_HAVE_TCM
/* /*
* We align everything to a page boundary so we can * We align everything to a page boundary so we can
......
...@@ -262,6 +262,8 @@ SECTIONS ...@@ -262,6 +262,8 @@ SECTIONS
} }
_edata_loc = __data_loc + SIZEOF(.data); _edata_loc = __data_loc + SIZEOF(.data);
BUG_TABLE
#ifdef CONFIG_HAVE_TCM #ifdef CONFIG_HAVE_TCM
/* /*
* We align everything to a page boundary so we can * We align everything to a page boundary so we can
......
...@@ -75,6 +75,7 @@ SECTIONS ...@@ -75,6 +75,7 @@ SECTIONS
_edata = .; _edata = .;
} }
BUG_TABLE
BSS_SECTION(0, 8, 8) BSS_SECTION(0, 8, 8)
_end = .; _end = .;
......
...@@ -115,6 +115,8 @@ SECTIONS ...@@ -115,6 +115,8 @@ SECTIONS
__data_lma = LOADADDR(.data); __data_lma = LOADADDR(.data);
__data_len = SIZEOF(.data); __data_len = SIZEOF(.data);
BUG_TABLE
/* The init section should be last, so when we free it, it goes into /* The init section should be last, so when we free it, it goes into
* the general memory pool, and (hopefully) will decrease fragmentation * the general memory pool, and (hopefully) will decrease fragmentation
* a tiny bit. The init section has a _requirement_ that it be * a tiny bit. The init section has a _requirement_ that it be
......
...@@ -128,6 +128,8 @@ SECTIONS ...@@ -128,6 +128,8 @@ SECTIONS
. = ALIGN(8); . = ALIGN(8);
} }
BUG_TABLE
_edata = .; _edata = .;
__bss_start = .; __bss_start = .;
......
...@@ -68,6 +68,8 @@ SECTIONS ...@@ -68,6 +68,8 @@ SECTIONS
__edata = . ; /* End of data section. */ __edata = . ; /* End of data section. */
_edata = . ; _edata = . ;
BUG_TABLE
INIT_TASK_DATA_SECTION(PAGE_SIZE) INIT_TASK_DATA_SECTION(PAGE_SIZE)
. = ALIGN(PAGE_SIZE); /* Init code and data. */ . = ALIGN(PAGE_SIZE); /* Init code and data. */
......
...@@ -102,6 +102,8 @@ SECTIONS ...@@ -102,6 +102,8 @@ SECTIONS
_edata = .; /* End of data section */ _edata = .; /* End of data section */
BUG_TABLE
/* GP section */ /* GP section */
. = ALIGN(L1_CACHE_BYTES); . = ALIGN(L1_CACHE_BYTES);
_gp = . + 2048; _gp = . + 2048;
......
...@@ -192,6 +192,8 @@ SECTIONS { ...@@ -192,6 +192,8 @@ SECTIONS {
CONSTRUCTORS CONSTRUCTORS
} }
BUG_TABLE
. = ALIGN(16); /* gp must be 16-byte aligned for exc. table */ . = ALIGN(16); /* gp must be 16-byte aligned for exc. table */
.got : AT(ADDR(.got) - LOAD_OFFSET) { .got : AT(ADDR(.got) - LOAD_OFFSET) {
*(.got.plt) *(.got.plt)
......
...@@ -97,6 +97,7 @@ SECTIONS ...@@ -97,6 +97,7 @@ SECTIONS
DATA_DATA DATA_DATA
CONSTRUCTORS CONSTRUCTORS
} }
BUG_TABLE
_gp = . + 0x8000; _gp = . + 0x8000;
.lit8 : { .lit8 : {
*(.lit8) *(.lit8)
......
...@@ -312,6 +312,8 @@ SECTIONS ...@@ -312,6 +312,8 @@ SECTIONS
NOSAVE_DATA NOSAVE_DATA
} }
BUG_TABLE
. = ALIGN(PAGE_SIZE); . = ALIGN(PAGE_SIZE);
_edata = .; _edata = .;
PROVIDE32 (edata = .); PROVIDE32 (edata = .);
......
...@@ -146,6 +146,7 @@ SECTIONS ...@@ -146,6 +146,7 @@ SECTIONS
_edata = .; _edata = .;
} :data } :data
BUG_TABLE
. = ALIGN(PAGE_SIZE); . = ALIGN(PAGE_SIZE);
__vvar_page = .; __vvar_page = .;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment